2015-08-21 13:06:54

by Aparna Karuthodi

Subject: [PATCH] staging: fbtft: Made into two lines

Made the comment into a new lineto remove a coding style error detected
by checkpatch.
The warning is given below:
drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters

Signed-off-by: Aparna Karuthodi <[email protected]>
---
drivers/staging/fbtft/fb_pcd8544.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
index 8b9ebfb..cf87ce8 100644
--- a/drivers/staging/fbtft/fb_pcd8544.c
+++ b/drivers/staging/fbtft/fb_pcd8544.c
@@ -34,7 +34,8 @@
#define WIDTH 84
#define HEIGHT 48
#define TXBUFLEN (84*6)
-#define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this driver */
+#define DEFAULT_GAMMA "40"
+/* gamma is used to control contrast in this driver */

static unsigned tc;
module_param(tc, uint, 0);
--
1.7.9.5

2015-08-23 07:53:45

by Giedrius Statkevičius

Subject: Re: [PATCH] staging: fbtft: Made into two lines

On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote:
> Made the comment into a new lineto remove a coding style error detected
> by checkpatch.
> The warning is given below:
> drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters
>
> Signed-off-by: Aparna Karuthodi <[email protected]>
> ---
> drivers/staging/fbtft/fb_pcd8544.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index 8b9ebfb..cf87ce8 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -34,7 +34,8 @@
> #define WIDTH 84
> #define HEIGHT 48
> #define TXBUFLEN (84*6)
> -#define DEFAULT_GAMMA "40" /* gamma is used to control contrast in this driver */
> +#define DEFAULT_GAMMA "40"
> +/* gamma is used to control contrast in this driver */

I think the format is usually:
/* comment */
#define FOO BAR

>
> static unsigned tc;
> module_param(tc, uint, 0);
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

2015-08-23 13:28:37

by Aparna Karuthodi

Subject: [PATCH] staging: fbtft: Made into two lines

Oh! Sorry! I made the changes to correct the faults you figured out.
Is it okay now?

Signed-off-by: Aparna Karuthodi <[email protected]>
---
drivers/staging/fbtft/fb_pcd8544.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
index cf87ce8..925511f 100644
--- a/drivers/staging/fbtft/fb_pcd8544.c
+++ b/drivers/staging/fbtft/fb_pcd8544.c
@@ -34,8 +34,8 @@
#define WIDTH 84
#define HEIGHT 48
#define TXBUFLEN (84*6)
-#define DEFAULT_GAMMA "40"
/* gamma is used to control contrast in this driver */
+#define DEFAULT_GAMMA "40"

static unsigned tc;
module_param(tc, uint, 0);
--
1.7.9.5

2015-08-24 13:11:27

by Sudip Mukherjee

Subject: Re: [PATCH] staging: fbtft: Made into two lines

On Fri, Aug 21, 2015 at 06:38:39PM +0530, Aparna Karuthodi wrote:
> Made the comment into a new lineto remove a coding style error detected
> by checkpatch.
> The warning is given below:
> drivers/staging/fbtft/fb_pcd8544.c:37: WARNING: line over 80 characters
>
> Signed-off-by: Aparna Karuthodi <[email protected]>
> ---
Please update your tree. This will also not apply for:
4178549e4c47 ("Staging: fbtft: fb_pcd8544: Fix comments style")

regards
sudip

2015-08-24 19:09:14

by Giedrius Statkevičius

Subject: Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote:
> Oh! Sorry! I made the changes to correct the faults you figured out.
> Is it okay now?

Resubmit it properly with "PATCH v2" in the title and a good commit message.

>
> Signed-off-by: Aparna Karuthodi <[email protected]>
> ---
> drivers/staging/fbtft/fb_pcd8544.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index cf87ce8..925511f 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -34,8 +34,8 @@
> #define WIDTH 84
> #define HEIGHT 48
> #define TXBUFLEN (84*6)
> -#define DEFAULT_GAMMA "40"
> /* gamma is used to control contrast in this driver */

Isn't this comment supposed to be on the previous line (the removed line)?
Check if you haven't messed this up

> +#define DEFAULT_GAMMA "40"
>
> static unsigned tc;
> module_param(tc, uint, 0);
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

2015-08-24 19:35:06

by Giedrius Statkevičius

Subject: Re: [PATCH] staging: fbtft: Made into two lines

On Sun, Aug 23, 2015 at 07:00:23PM +0530, Aparna Karuthodi wrote:
> Oh! Sorry! I made the changes to correct the faults you figured out.
> Is it okay now?

Better. Also, submit it again with proper commit message and put "PATCH v2" in
the subject.

>
> Signed-off-by: Aparna Karuthodi <[email protected]>
> ---
> drivers/staging/fbtft/fb_pcd8544.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.c
> index cf87ce8..925511f 100644
> --- a/drivers/staging/fbtft/fb_pcd8544.c
> +++ b/drivers/staging/fbtft/fb_pcd8544.c
> @@ -34,8 +34,8 @@
> #define WIDTH 84
> #define HEIGHT 48
> #define TXBUFLEN (84*6)
> -#define DEFAULT_GAMMA "40"
> /* gamma is used to control contrast in this driver */

Aren't these two supposed to be on the same line? I think your patch is a bit
messed up. Doublecheck this.

> +#define DEFAULT_GAMMA "40"
>
> static unsigned tc;
> module_param(tc, uint, 0);
> --
> 1.7.9.5
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel