2015-08-27 15:08:01

by Luis de Bethencourt

Subject: [PATCH] usb: musb: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <[email protected]>
---
drivers/usb/musb/ux500.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
index 39168fe..b2685e7 100644
--- a/drivers/usb/musb/ux500.c
+++ b/drivers/usb/musb/ux500.c
@@ -379,6 +379,8 @@ static const struct of_device_id ux500_match[] = {
{}
};

+MODULE_DEVICE_TABLE(of, ux500_match);
+
static struct platform_driver ux500_driver = {
.probe = ux500_probe,
.remove = ux500_remove,
--
2.4.6

2015-08-27 15:41:45

by Bin Liu

Subject: Re: [PATCH] usb: musb: Fix module autoload for OF platform driver

Hi,

On Thu, Aug 27, 2015 at 10:07 AM, Luis de Bethencourt
<[email protected]> wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.

Care to add 'ux500' to the summary line - 'usb: musb: ux500: Fix...'?
That helps filtering in git-log.

Thanks,
-Bin.

>
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
> drivers/usb/musb/ux500.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
> index 39168fe..b2685e7 100644
> --- a/drivers/usb/musb/ux500.c
> +++ b/drivers/usb/musb/ux500.c
> @@ -379,6 +379,8 @@ static const struct of_device_id ux500_match[] = {
> {}
> };
>
> +MODULE_DEVICE_TABLE(of, ux500_match);
> +
> static struct platform_driver ux500_driver = {
> .probe = ux500_probe,
> .remove = ux500_remove,
> --
> 2.4.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2015-08-27 15:49:08

by Luis de Bethencourt

Subject: Re: [PATCH] usb: musb: Fix module autoload for OF platform driver

On Thu, Aug 27, 2015 at 10:41:42AM -0500, Bin Liu wrote:
> Hi,
>
> On Thu, Aug 27, 2015 at 10:07 AM, Luis de Bethencourt
> <[email protected]> wrote:
> > This platform driver has a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
>
> Care to add 'ux500' to the summary line - 'usb: musb: ux500: Fix...'?
> That helps filtering in git-log.
>
> Thanks,
> -Bin.
>

Off course. Sent a second version with 'usb: musb: ux500:' in the commit
subject.

Thanks for reviewing,
Luis

> >
> > Signed-off-by: Luis de Bethencourt <[email protected]>
> > ---
> > drivers/usb/musb/ux500.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/usb/musb/ux500.c b/drivers/usb/musb/ux500.c
> > index 39168fe..b2685e7 100644
> > --- a/drivers/usb/musb/ux500.c
> > +++ b/drivers/usb/musb/ux500.c
> > @@ -379,6 +379,8 @@ static const struct of_device_id ux500_match[] = {
> > {}
> > };
> >
> > +MODULE_DEVICE_TABLE(of, ux500_match);
> > +
> > static struct platform_driver ux500_driver = {
> > .probe = ux500_probe,
> > .remove = ux500_remove,
> > --
> > 2.4.6
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/