2015-08-27 16:59:13

by Luis de Bethencourt

Subject: [PATCH 2/6] input: pwm-beeper: Fix module autoload for OF platform driver

This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.

Signed-off-by: Luis de Bethencourt <[email protected]>
---
drivers/input/misc/pwm-beeper.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
index e82edf8..a02b9a4 100644
--- a/drivers/input/misc/pwm-beeper.c
+++ b/drivers/input/misc/pwm-beeper.c
@@ -175,6 +175,8 @@ static const struct of_device_id pwm_beeper_match[] = {
};
#endif

+MODULE_DEVICE_TABLE(of, pwm_beeper_match);
+
static struct platform_driver pwm_beeper_driver = {
.probe = pwm_beeper_probe,
.remove = pwm_beeper_remove,
--
2.4.6

2015-08-29 00:00:44

by Dmitry Torokhov

Subject: Re: [PATCH 2/6] input: pwm-beeper: Fix module autoload for OF platform driver

Hi Luis,

On Thu, Aug 27, 2015 at 9:59 AM, Luis de Bethencourt
<[email protected]> wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <[email protected]>
> ---
> drivers/input/misc/pwm-beeper.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index e82edf8..a02b9a4 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -175,6 +175,8 @@ static const struct of_device_id pwm_beeper_match[] = {
> };
> #endif
>
> +MODULE_DEVICE_TABLE(of, pwm_beeper_match);
> +

I'm fairly certain this (ano others) blow up in case of !CONFIG_OF.
Please bring MODULE_DEVICE_TABLE into #ifdef block above.

> static struct platform_driver pwm_beeper_driver = {
> .probe = pwm_beeper_probe,
> .remove = pwm_beeper_remove,
> --
> 2.4.6
>

Thanks.

--
Dmitry