2015-11-08 06:58:16

by Ivan Safonov

Subject: [PATCH 10/12] staging: rtl8188eu: reg_macid variable removed in hw_var_set_macaddr

The reg_macid variable used only once. Also idx renamed to i and Adapter to adapter.

Signed-off-by: Ivan Safonov <[email protected]>
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 5789e1e..e1d6632 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -1253,15 +1253,12 @@ static void hw_var_set_opmode(struct adapter *Adapter, u8 variable, u8 *val)
}
}

-static void hw_var_set_macaddr(struct adapter *Adapter, u8 variable, u8 *val)
+static void hw_var_set_macaddr(struct adapter *adapter, u8 variable, u8 *val)
{
- u8 idx = 0;
- u32 reg_macid;
-
- reg_macid = REG_MACID;
+ int i;

- for (idx = 0; idx < 6; idx++)
- usb_write8(Adapter, (reg_macid+idx), val[idx]);
+ for (i = 0; i < 6; i++)
+ usb_write8(adapter, REG_MACID + i, val[i]);
}

static void hw_var_set_bssid(struct adapter *Adapter, u8 variable, u8 *val)
--
2.4.10

2015-11-08 20:16:24

by Andy Shevchenko

Subject: Re: [PATCH 10/12] staging: rtl8188eu: reg_macid variable removed in hw_var_set_macaddr

On Sun, Nov 8, 2015 at 8:51 AM, Ivan Safonov <[email protected]> wrote:
> The reg_macid variable used only once. Also idx renamed to i and Adapter to adapter.
>
> Signed-off-by: Ivan Safonov <[email protected]>
> ---
> drivers/staging/rtl8188eu/hal/usb_halinit.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> index 5789e1e..e1d6632 100644
> --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> @@ -1253,15 +1253,12 @@ static void hw_var_set_opmode(struct adapter *Adapter, u8 variable, u8 *val)
> }
> }
>
> -static void hw_var_set_macaddr(struct adapter *Adapter, u8 variable, u8 *val)
> +static void hw_var_set_macaddr(struct adapter *adapter, u8 variable, u8 *val)
> {
> - u8 idx = 0;
> - u32 reg_macid;
> -
> - reg_macid = REG_MACID;
> + int i;
>
> - for (idx = 0; idx < 6; idx++)
> - usb_write8(Adapter, (reg_macid+idx), val[idx]);
> + for (i = 0; i < 6; i++)

ETH_ALEN?

> + usb_write8(adapter, REG_MACID + i, val[i]);
> }
>
> static void hw_var_set_bssid(struct adapter *Adapter, u8 variable, u8 *val)
> --
> 2.4.10
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/



--
With Best Regards,
Andy Shevchenko