2015-11-25 01:10:51

by Jin Qian

Subject: [PATCH 4/8] platform: goldfish: pipe: add devicetree bindings

From: Greg Hackmann <[email protected]>

Signed-off-by: Greg Hackmann <[email protected]>
(cherry picked from commit 3c56d07eb796066530e93a40e74dea3bc59bf4cf)
Signed-off-by: Jin Qian <[email protected]>
---
drivers/platform/goldfish/goldfish_pipe.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index 20a9337..86cc57f 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -624,11 +624,19 @@ static int goldfish_pipe_remove(struct platform_device *pdev)
return 0;
}

+static const struct of_device_id goldfish_pipe_of_match[] = {
+ { .compatible = "generic,android-pipe", },
+ {},
+};
+MODULE_DEVICE_TABLE(of, goldfish_pipe_of_match);
+
static struct platform_driver goldfish_pipe = {
.probe = goldfish_pipe_probe,
.remove = goldfish_pipe_remove,
.driver = {
- .name = "goldfish_pipe"
+ .name = "goldfish_pipe",
+ .owner = THIS_MODULE,
+ .of_match_table = goldfish_pipe_of_match,
}
};

--
2.6.0.rc2.230.g3dd15c0

2015-11-25 11:22:19

by Christoffer Dall

Subject: Re: [PATCH 4/8] platform: goldfish: pipe: add devicetree bindings

On Tue, Nov 24, 2015 at 05:10:08PM -0800, Jin Qian wrote:
> From: Greg Hackmann <[email protected]>
>
> Signed-off-by: Greg Hackmann <[email protected]>
> (cherry picked from commit 3c56d07eb796066530e93a40e74dea3bc59bf4cf)
> Signed-off-by: Jin Qian <[email protected]>
> ---
> drivers/platform/goldfish/goldfish_pipe.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
> index 20a9337..86cc57f 100644
> --- a/drivers/platform/goldfish/goldfish_pipe.c
> +++ b/drivers/platform/goldfish/goldfish_pipe.c
> @@ -624,11 +624,19 @@ static int goldfish_pipe_remove(struct platform_device *pdev)
> return 0;
> }
>
> +static const struct of_device_id goldfish_pipe_of_match[] = {
> + { .compatible = "generic,android-pipe", },
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, goldfish_pipe_of_match);
> +
> static struct platform_driver goldfish_pipe = {
> .probe = goldfish_pipe_probe,
> .remove = goldfish_pipe_remove,
> .driver = {
> - .name = "goldfish_pipe"
> + .name = "goldfish_pipe",
> + .owner = THIS_MODULE,
> + .of_match_table = goldfish_pipe_of_match,
> }
> };
>
I think this needs something documented in
Documentation/devicetree/bindings as well.

-Christoffer