2015-12-08 18:05:58

by Steve Twiss

Subject: [PATCH V1] input: da9063: report KEY_POWER instead of KEY_SLEEP during power key-press

From: Steve Twiss <[email protected]>

Stop reporting KEY_SLEEP for a short key-press and report KEY_POWER instead
This change applied to both DA9063 and DA9062 ONKEY drivers.

Signed-off-by: Steve Twiss <[email protected]>

---

This patch applies against linux-next and v4.4-rc4

Regards,
Steve


drivers/input/misc/da9063_onkey.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
index 8eb697d..bb863e0 100644
--- a/drivers/input/misc/da9063_onkey.c
+++ b/drivers/input/misc/da9063_onkey.c
@@ -179,13 +179,13 @@ static irqreturn_t da9063_onkey_irq_handler(int irq, void *data)
input_report_key(onkey->input, KEY_POWER, 1);
input_sync(onkey->input);
schedule_delayed_work(&onkey->work, 0);
- dev_dbg(onkey->dev, "KEY_POWER pressed.\n");
+ dev_dbg(onkey->dev, "KEY_POWER long press.\n");
} else {
- input_report_key(onkey->input, KEY_SLEEP, 1);
+ input_report_key(onkey->input, KEY_POWER, 1);
input_sync(onkey->input);
- input_report_key(onkey->input, KEY_SLEEP, 0);
+ input_report_key(onkey->input, KEY_POWER, 0);
input_sync(onkey->input);
- dev_dbg(onkey->dev, "KEY_SLEEP pressed.\n");
+ dev_dbg(onkey->dev, "KEY_POWER short press.\n");
}

return IRQ_HANDLED;
--
end-of-patch for PATCH V1

2015-12-09 17:17:09

by Dmitry Torokhov

Subject: Re: [PATCH V1] input: da9063: report KEY_POWER instead of KEY_SLEEP during power key-press

On Tue, Dec 08, 2015 at 05:55:05PM +0000, Steve Twiss wrote:
> From: Steve Twiss <[email protected]>
>
> Stop reporting KEY_SLEEP for a short key-press and report KEY_POWER instead
> This change applied to both DA9063 and DA9062 ONKEY drivers.

You need to explain why this change is needed.

>
> Signed-off-by: Steve Twiss <[email protected]>
>
> ---
>
> This patch applies against linux-next and v4.4-rc4
>
> Regards,
> Steve
>
>
> drivers/input/misc/da9063_onkey.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c
> index 8eb697d..bb863e0 100644
> --- a/drivers/input/misc/da9063_onkey.c
> +++ b/drivers/input/misc/da9063_onkey.c
> @@ -179,13 +179,13 @@ static irqreturn_t da9063_onkey_irq_handler(int irq, void *data)
> input_report_key(onkey->input, KEY_POWER, 1);
> input_sync(onkey->input);
> schedule_delayed_work(&onkey->work, 0);
> - dev_dbg(onkey->dev, "KEY_POWER pressed.\n");
> + dev_dbg(onkey->dev, "KEY_POWER long press.\n");
> } else {
> - input_report_key(onkey->input, KEY_SLEEP, 1);
> + input_report_key(onkey->input, KEY_POWER, 1);
> input_sync(onkey->input);
> - input_report_key(onkey->input, KEY_SLEEP, 0);
> + input_report_key(onkey->input, KEY_POWER, 0);
> input_sync(onkey->input);
> - dev_dbg(onkey->dev, "KEY_SLEEP pressed.\n");
> + dev_dbg(onkey->dev, "KEY_POWER short press.\n");
> }
>
> return IRQ_HANDLED;
> --
> end-of-patch for PATCH V1
>

--
Dmitry