2016-03-03 15:29:31

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH v3 1/4] dmaengine: xilinx_vdma: Improve SG engine handling

On Fri, Feb 26, 2016 at 07:33:51PM +0530, Kedareswara rao Appana wrote:
> The current driver allows user to queue up multiple segments
> on to a single transaction descriptor. User will submit this single desc
> and in the issue_pending() we decode multiple segments and submit to SG HW engine.
> We free up the allocated_desc when it is submitted to the HW.
>
> Existing code prevents the user to prepare multiple trasactions at same time as
> we are overwrite with the allocated_desc.
>
> The best utilization of HW SG engine would happen if we collate the pending
> list when we start dma this patch updates the same.

Applied all. It is usually advisable to do cover letter using --cover-letter
for multi patch series

--
~Vinod


Subject: RE: [PATCH v3 1/4] dmaengine: xilinx_vdma: Improve SG engine handling

> -----Original Message-----
> From: Vinod Koul [mailto:[email protected]]
> Sent: Thursday, March 03, 2016 9:03 PM
> To: Appana Durga Kedareswara Rao
> Cc: [email protected]; Michal Simek; Soren Brinkmann; Appana Durga
> Kedareswara Rao; [email protected];
> [email protected]; [email protected]; Anirudha
> Sarangi; [email protected]; [email protected];
> [email protected]
> Subject: Re: [PATCH v3 1/4] dmaengine: xilinx_vdma: Improve SG engine
> handling
>
> On Fri, Feb 26, 2016 at 07:33:51PM +0530, Kedareswara rao Appana wrote:
> > The current driver allows user to queue up multiple segments on to a
> > single transaction descriptor. User will submit this single desc and
> > in the issue_pending() we decode multiple segments and submit to SG HW
> engine.
> > We free up the allocated_desc when it is submitted to the HW.
> >
> > Existing code prevents the user to prepare multiple trasactions at
> > same time as we are overwrite with the allocated_desc.
> >
> > The best utilization of HW SG engine would happen if we collate the
> > pending list when we start dma this patch updates the same.
>
> Applied all. It is usually advisable to do cover letter using --cover-letter for multi
> patch series

Thanks ... Will fix next time onwards...

Regards,
Kedar.

>
> --
> ~Vinod