2016-03-08 17:21:12

by Chris Leech

[permalink] [raw]
Subject: Re: [PATCH] Use ida_simple for SCSI iSCSI transport session id

On Fri, Feb 12, 2016 at 09:38:53AM -0800, Lee Duncan wrote:
> The scsi_transport_iscsi module already uses the ida_simple
> routines for managing the target ID, if requested to do
> so. This change replaces an ever-increasing atomic integer
> that tracks the session ID itself with the ida_simple
> family of routines. This means that the session ID
> will be reclaimed and can be reused when the session
> is freed.
>
> Note that no maximum is placed on this value, though
> user-space currently only seems to use the lower 24-bits.
> It seems better to handle this in user space, though,
> than to limit the value range for the session ID here.
>
> Signed-off-by: Lee Duncan <[email protected]>

Acked-by: Chris Leech <[email protected]>