2016-03-24 20:51:24

by Michal Marek

[permalink] [raw]
Subject: [GIT PULL] kconfig changes for v4.6-rc1

Hi Linus,

just two kconfig commits this time:
- kconfig Makefile fix for make 3.80
- Fix calculating symbols so that KCONFIG_ALLCONFIG=... does not disable
CONFIG_MODULES silently

Michal

The following changes since commit 92e963f50fc74041b5e9e744c330dca48e04f08d:

Linux 4.5-rc1 (2016-01-24 13:06:47 -0800)

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git kconfig

for you to fetch changes up to 6b87b70c5339f30e3c5b32085e69625906513dc2:

unbreak allmodconfig KCONFIG_ALLCONFIG=... (2016-02-01 15:12:40 +0100)

----------------------------------------------------------------
Al Viro (1):
unbreak allmodconfig KCONFIG_ALLCONFIG=...

Jan Beulich (1):
scripts/kconfig: allow building with make 3.80 again

scripts/kconfig/Makefile | 4 +++-
scripts/kconfig/confdata.c | 12 +++++++-----
2 files changed, 10 insertions(+), 6 deletions(-)


2016-03-25 08:54:50

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [GIT PULL] kconfig changes for v4.6-rc1

Hi Michal, Al,

On Thu, Mar 24, 2016 at 9:51 PM, Michal Marek <[email protected]> wrote:
> just two kconfig commits this time:
> - kconfig Makefile fix for make 3.80
> - Fix calculating symbols so that KCONFIG_ALLCONFIG=... does not disable
> CONFIG_MODULES silently

> for you to fetch changes up to 6b87b70c5339f30e3c5b32085e69625906513dc2:
>
> unbreak allmodconfig KCONFIG_ALLCONFIG=... (2016-02-01 15:12:40 +0100)
>
> ----------------------------------------------------------------
> Al Viro (1):
> unbreak allmodconfig KCONFIG_ALLCONFIG=...

I can now indeed drop the

CONFIG_MODULES=y

line from my

allmod.config

However, this fix has the side-effect of enabling CONFIG_MODULES silently for

make allyesconfig KCONFIG_ALLCONFIG=1

Adding an explicit

CONFIG_MODULES=n

to the allyes.config file fixes that.

IMHO CONFIG_MODULES should default to y when using allmodconfig, and
default to n when using allyesconfig.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2016-03-25 09:03:45

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [GIT PULL] kconfig changes for v4.6-rc1

On Fri, Mar 25, 2016 at 9:54 AM, Geert Uytterhoeven
<[email protected]> wrote:
> On Thu, Mar 24, 2016 at 9:51 PM, Michal Marek <[email protected]> wrote:
>> just two kconfig commits this time:
>> - kconfig Makefile fix for make 3.80
>> - Fix calculating symbols so that KCONFIG_ALLCONFIG=... does not disable
>> CONFIG_MODULES silently
>
>> for you to fetch changes up to 6b87b70c5339f30e3c5b32085e69625906513dc2:
>>
>> unbreak allmodconfig KCONFIG_ALLCONFIG=... (2016-02-01 15:12:40 +0100)
>>
>> ----------------------------------------------------------------
>> Al Viro (1):
>> unbreak allmodconfig KCONFIG_ALLCONFIG=...
>
> I can now indeed drop the
>
> CONFIG_MODULES=y
>
> line from my
>
> allmod.config
>
> However, this fix has the side-effect of enabling CONFIG_MODULES silently for
>
> make allyesconfig KCONFIG_ALLCONFIG=1
>
> Adding an explicit
>
> CONFIG_MODULES=n
>
> to the allyes.config file fixes that.
>
> IMHO CONFIG_MODULES should default to y when using allmodconfig, and
> default to n when using allyesconfig.

Hmm, it seems plain "make allyesconfig" also enables CONFIG_MODULES, and
makes many options modular. Is that intentional, especially the latter?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2016-03-30 13:29:43

by Michal Marek

[permalink] [raw]
Subject: Re: [GIT PULL] kconfig changes for v4.6-rc1

On 2016-03-25 10:03, Geert Uytterhoeven wrote:
> On Fri, Mar 25, 2016 at 9:54 AM, Geert Uytterhoeven
>>> Al Viro (1):
>>> unbreak allmodconfig KCONFIG_ALLCONFIG=...
>>
>> I can now indeed drop the
>>
>> CONFIG_MODULES=y
>>
>> line from my
>>
>> allmod.config
>>
>> However, this fix has the side-effect of enabling CONFIG_MODULES silently for
>>
>> make allyesconfig KCONFIG_ALLCONFIG=1
>>
>> Adding an explicit
>>
>> CONFIG_MODULES=n
>>
>> to the allyes.config file fixes that.
>>
>> IMHO CONFIG_MODULES should default to y when using allmodconfig, and
>> default to n when using allyesconfig.
>
> Hmm, it seems plain "make allyesconfig" also enables CONFIG_MODULES, and
> makes many options modular. Is that intentional, especially the latter?

allyesconfig builds everything into the kernel, so why exclude the
module loader. And there are a few modules with a 'depends on m'
statement, either because this is test code in samples/ which is not
even considered when linking the kernel, or there is some "issue" when
the code is built-in. The statement might also be completely bogus, but
that's not a job of allyesconfig to decide.

Michal