2016-03-23 22:05:44

by Matthew McClintock

Subject: [PATCH 02/17] pinctrl: qcom: ipq4019: fix the function enum for gpio mode

Without this, we would fail to set the mode to gpio if trying to
configure for that mode

CC: [email protected]
CC: [email protected]
Signed-off-by: Matthew McClintock <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
index cb5f0a8..cb9f16a 100644
--- a/drivers/pinctrl/qcom/pinctrl-ipq4019.c
+++ b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
@@ -237,7 +237,7 @@ DECLARE_QCA_GPIO_PINS(99);
.pins = gpio##id##_pins, \
.npins = (unsigned)ARRAY_SIZE(gpio##id##_pins), \
.funcs = (int[]){ \
- qca_mux_NA, /* gpio mode */ \
+ qca_mux_gpio, /* gpio mode */ \
qca_mux_##f1, \
qca_mux_##f2, \
qca_mux_##f3, \
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2016-03-25 21:23:05

by Bjorn Andersson

Subject: Re: [PATCH 02/17] pinctrl: qcom: ipq4019: fix the function enum for gpio mode

On Wed 23 Mar 15:04 PDT 2016, Matthew McClintock wrote:

> Without this, we would fail to set the mode to gpio if trying to
> configure for that mode
>
> CC: [email protected]

Linus is the maintainer of the pinctrl subsystem, as such you should
have him as recipient of these patches - so that he doesn't miss them
while being only Cc.

Acked-by: [email protected]

Regards,
Bjorn

> Signed-off-by: Matthew McClintock <[email protected]>
> ---
> drivers/pinctrl/qcom/pinctrl-ipq4019.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq4019.c b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> index cb5f0a8..cb9f16a 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq4019.c
> @@ -237,7 +237,7 @@ DECLARE_QCA_GPIO_PINS(99);
> .pins = gpio##id##_pins, \
> .npins = (unsigned)ARRAY_SIZE(gpio##id##_pins), \
> .funcs = (int[]){ \
> - qca_mux_NA, /* gpio mode */ \
> + qca_mux_gpio, /* gpio mode */ \
> qca_mux_##f1, \
> qca_mux_##f2, \
> qca_mux_##f3, \
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>

2016-03-31 09:55:25

by Linus Walleij

Subject: Re: [PATCH 02/17] pinctrl: qcom: ipq4019: fix the function enum for gpio mode

On Wed, Mar 23, 2016 at 11:04 PM, Matthew McClintock
<[email protected]> wrote:

> Without this, we would fail to set the mode to gpio if trying to
> configure for that mode
>
> CC: [email protected]
> CC: [email protected]
> Signed-off-by: Matthew McClintock <[email protected]>

Patch applied for fixes with Björn's ACK.

Yours,
Linus Walleij