2016-04-07 17:40:35

by Chris Bainbridge

[permalink] [raw]
Subject: Re: [PATCH] usb: core: hub: hub_port_init lock controller instead of bus

On Wed, Feb 10, 2016 at 07:13:38PM +0200, Mathias Nyman wrote:
>
> Most likely xhci is messed up after two device slots are in default state at the same time.
> This happens when both threads are in hub_port_init() have called hub_port_reset()
>
> The issue becomes visible when the the descriptor read and set address both fail after
> the port resets.
>
> xhci specs 4.5.3 has one tiny note about this:
> "Note: Software shall not transition more than one Device Slot to the Default State at a time"
>
> So to me, and from xhci pov this patch looks like the correct solution,
> but I might be missing some usb core side details.
>
> -Mathias
>

Just following up to see if this patch disappeared into the void?