2016-04-20 06:36:01

by Andreas Werner

Subject: [PATCH] mcb: Fixed bar number assignment for the gdd

The bar number is found in reg2 within the gdd. Therefore
we need to change the assigment from reg1 to reg2 which
is the correct location.

Signed-off-by: Andreas Werner <[email protected]>
---
drivers/mcb/mcb-parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c
index 0049269..b0155b0 100644
--- a/drivers/mcb/mcb-parse.c
+++ b/drivers/mcb/mcb-parse.c
@@ -57,7 +57,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus,
mdev->id = GDD_DEV(reg1);
mdev->rev = GDD_REV(reg1);
mdev->var = GDD_VAR(reg1);
- mdev->bar = GDD_BAR(reg1);
+ mdev->bar = GDD_BAR(reg2);
mdev->group = GDD_GRP(reg2);
mdev->inst = GDD_INS(reg2);

--
2.6.2

2016-04-20 08:58:07

by Johannes Thumshirn

Subject: Re: [PATCH] mcb: Fixed bar number assignment for the gdd

On Wed, Apr 20, 2016 at 08:35:47AM +0200, Andreas Werner wrote:
> The bar number is found in reg2 within the gdd. Therefore
> we need to change the assigment from reg1 to reg2 which
> is the correct location.
>
> Signed-off-by: Andreas Werner <[email protected]>
> ---
> drivers/mcb/mcb-parse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c
> index 0049269..b0155b0 100644
> --- a/drivers/mcb/mcb-parse.c
> +++ b/drivers/mcb/mcb-parse.c
> @@ -57,7 +57,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus,
> mdev->id = GDD_DEV(reg1);
> mdev->rev = GDD_REV(reg1);
> mdev->var = GDD_VAR(reg1);
> - mdev->bar = GDD_BAR(reg1);
> + mdev->bar = GDD_BAR(reg2);
> mdev->group = GDD_GRP(reg2);
> mdev->inst = GDD_INS(reg2);
>
> --
> 2.6.2
>

Applied, thanks.

--
Johannes Thumshirn Storage
[email protected] +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Felix Imend?rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N?rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850