From: Jim Lodes <[email protected]>
Initialize the dma_slave_config for PCM DMA transfers,
instead of leaving it uninitialized. Keeps previous data on
the stack from giving us invalid values in uninitialized
members of the config structure.
Signed-off-by: Jim Lodes <[email protected]>
Signed-off-by: J.D. Schroeder <[email protected]>
---
sound/soc/omap/omap-pcm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index 99381a2..a84f677 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
struct dma_chan *chan;
int err = 0;
+ memset(&config, 0x00, sizeof(config));
+
dma_data = snd_soc_dai_get_dma_data(rtd->cpu_dai, substream);
/* return if this is a bufferless transfer e.g.
--
1.9.1
On Mon, Apr 25, 2016 at 11:10:07AM -0500, J.D. Schroeder wrote:
> From: Jim Lodes <[email protected]>
>
> Initialize the dma_slave_config for PCM DMA transfers,
> instead of leaving it uninitialized. Keeps previous data on
> the stack from giving us invalid values in uninitialized
> members of the config structure.
>
> Signed-off-by: Jim Lodes <[email protected]>
> Signed-off-by: J.D. Schroeder <[email protected]>
> ---
> sound/soc/omap/omap-pcm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
> index 99381a2..a84f677 100644
> --- a/sound/soc/omap/omap-pcm.c
> +++ b/sound/soc/omap/omap-pcm.c
> @@ -82,6 +82,8 @@ static int omap_pcm_hw_params(struct snd_pcm_substream *substream,
> struct dma_chan *chan;
> int err = 0;
>
> + memset(&config, 0x00, sizeof(config));
Based on a894bd7fb539 ("ASoC: generic-dmaengine-pcm: Clear slave_config
memory")
Acked-by: Jarkko Nikula <[email protected]>
Reviewed-by: Jarkko Nikula <[email protected]>