2016-10-23 21:05:42

by Nadim Almas

Subject: [PATCH] Staging:board:board: fix implicit declaration of function

implicit declaration of function ‘of_find_all_nodes’ reported by sparse

Signed-off-by: Nadim Almas <[email protected]>
---
drivers/staging/board/board.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/board/board.c b/drivers/staging/board/board.c
index 86dc411..6978db5 100644
--- a/drivers/staging/board/board.c
+++ b/drivers/staging/board/board.c
@@ -22,6 +22,7 @@

#include "board.h"

+struct device_node *of_find_all_nodes(struct device_node *);
static struct device_node *irqc_node __initdata;
static unsigned int irqc_base __initdata;

--
2.7.4

2016-10-24 10:47:13

by Dan Carpenter

Subject: Re: [PATCH] Staging:board:board: fix implicit declaration of function

On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote:
> implicit declaration of function ‘of_find_all_nodes’ reported by sparse
>

No. Include the correct header file instead.

regards,
dan carpenter

2016-10-24 11:11:45

by Geert Uytterhoeven

Subject: Re: [PATCH] Staging:board:board: fix implicit declaration of function

On Mon, Oct 24, 2016 at 12:46 PM, Dan Carpenter
<[email protected]> wrote:
> On Mon, Oct 24, 2016 at 02:35:26AM +0530, Nadim Almas wrote:
>> implicit declaration of function ‘of_find_all_nodes’ reported by sparse
>>
>
> No. Include the correct header file instead.

drivers/staging/board/board.c already includes <linux/of.h>, which provides
the prototype, but only if CONFIG_OF=y.

However, STAGING_BOARD depends on OF_ADDRESS and OF_IRQ,
which both depend on OF. So how can this happen??

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds