2016-10-24 09:52:37

by Brian Starkey

Subject: [PATCH] drm: mali-dp: Don't set DRM_PLANE_COMMIT_ACTIVE_ONLY

We need to explicitly disable our planes, so don't set the flag which
would otherwise skip the plane disable when the CRTC is disabled.

Signed-off-by: Brian Starkey <[email protected]>
---
drivers/gpu/drm/arm/malidp_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
index 9ed938e..f7bb763 100644
--- a/drivers/gpu/drm/arm/malidp_drv.c
+++ b/drivers/gpu/drm/arm/malidp_drv.c
@@ -102,8 +102,7 @@ static void malidp_atomic_commit_tail(struct drm_atomic_state *state)
*/
malidp_mw_atomic_commit(drm, state);

- drm_atomic_helper_commit_planes(drm, state,
- DRM_PLANE_COMMIT_ACTIVE_ONLY);
+ drm_atomic_helper_commit_planes(drm, state, 0);

malidp_atomic_commit_hw_done(state);

--
1.7.9.5

2016-10-24 09:56:18

by Liviu Dudau

Subject: Re: [PATCH] drm: mali-dp: Don't set DRM_PLANE_COMMIT_ACTIVE_ONLY

On Mon, Oct 24, 2016 at 10:52:28AM +0100, Brian Starkey wrote:
> We need to explicitly disable our planes, so don't set the flag which
> would otherwise skip the plane disable when the CRTC is disabled.
>
> Signed-off-by: Brian Starkey <[email protected]>

Acked-by: Liviu Dudau <[email protected]>

> ---
> drivers/gpu/drm/arm/malidp_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c
> index 9ed938e..f7bb763 100644
> --- a/drivers/gpu/drm/arm/malidp_drv.c
> +++ b/drivers/gpu/drm/arm/malidp_drv.c
> @@ -102,8 +102,7 @@ static void malidp_atomic_commit_tail(struct drm_atomic_state *state)
> */
> malidp_mw_atomic_commit(drm, state);
>
> - drm_atomic_helper_commit_planes(drm, state,
> - DRM_PLANE_COMMIT_ACTIVE_ONLY);
> + drm_atomic_helper_commit_planes(drm, state, 0);
>
> malidp_atomic_commit_hw_done(state);
>
> --
> 1.7.9.5
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯