2016-11-15 13:25:00

by Rahul Krishnan

Subject: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block

This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Rahul Krishnan <[email protected]>
---
drivers/staging/greybus/sdio.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index 5649ef1..f60b458 100644
--- a/drivers/staging/greybus/sdio.c
+++ b/drivers/staging/greybus/sdio.c
@@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
state_changed = 1;
}

- if (event & GB_SDIO_WP) {
- host->read_only = true;
- }
+ if (event & GB_SDIO_WP)
+ host->read_only = true;

if (state_changed) {
dev_info(mmc_dev(host->mmc), "card %s now event\n",
--
2.10.2

2016-11-15 13:27:28

by Dan Carpenter

Subject: Re: [PATCH]: staging: Greybus: Remove unnecessary braces for single statement block

On Tue, Nov 15, 2016 at 06:54:33PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Rahul Krishnan <[email protected]>
> ---
> drivers/staging/greybus/sdio.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index 5649ef1..f60b458 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -191,9 +191,8 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
> state_changed = 1;
> }
>
> - if (event & GB_SDIO_WP) {
> - host->read_only = true;
> - }
> + if (event & GB_SDIO_WP)
> + host->read_only = true;

The indenting is messed up.

regards,
dan carpenter