2016-11-18 06:53:00

by Tao Zhou

Subject: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

The code actually checks rt_queued not rt_nr_running
in pick_next_task_rt(), so change the corresponding
comment.

Signed-off-by: T.Zhou <[email protected]>
---
kernel/sched/rt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 2516b8d..9b4a5c5 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1550,7 +1550,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct pin_cookie coo

/*
* We may dequeue prev's rt_rq in put_prev_task().
- * So, we update time before rt_nr_running check.
+ * So, we update time before rt_queued check.
*/
if (prev->sched_class == &rt_sched_class)
update_curr_rt(rq);
--
2.7.3

2016-11-18 14:53:18

by Steven Rostedt

Subject: Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

Peter,

Can you pull this patch into your queue?

Acked-by: Steven Rostedt <[email protected]>

-- Steve


On Fri, 18 Nov 2016 14:39:04 +0800
"T.Zhou" <[email protected]> wrote:

> The code actually checks rt_queued not rt_nr_running
> in pick_next_task_rt(), so change the corresponding
> comment.
>
> Signed-off-by: T.Zhou <[email protected]>
> ---
> kernel/sched/rt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
> index 2516b8d..9b4a5c5 100644
> --- a/kernel/sched/rt.c
> +++ b/kernel/sched/rt.c
> @@ -1550,7 +1550,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev, struct pin_cookie coo
>
> /*
> * We may dequeue prev's rt_rq in put_prev_task().
> - * So, we update time before rt_nr_running check.
> + * So, we update time before rt_queued check.
> */
> if (prev->sched_class == &rt_sched_class)
> update_curr_rt(rq);

2016-11-18 15:01:01

by Peter Zijlstra

Subject: Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

On Fri, Nov 18, 2016 at 09:53:07AM -0500, Steven Rostedt wrote:
>
> Peter,
>
> Can you pull this patch into your queue?

Not in my inbox..

2016-11-18 16:46:23

by Steven Rostedt

Subject: Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

On Fri, 18 Nov 2016 16:00:57 +0100
Peter Zijlstra <[email protected]> wrote:

> On Fri, Nov 18, 2016 at 09:53:07AM -0500, Steven Rostedt wrote:
> >
> > Peter,
> >
> > Can you pull this patch into your queue?
>
> Not in my inbox..

Can you get it from LKML? If not, I can bounce it to you.

-- Steve

2016-11-19 03:10:19

by Tao Zhou

Subject: Re: [PATCH] sched/rt: Change rt_nr_running to rt_queued in the comment

Hi Peter,

On Fri, Nov 18, 2016 at 04:00:57PM +0100, Peter Zijlstra wrote:
> On Fri, Nov 18, 2016 at 09:53:07AM -0500, Steven Rostedt wrote:
> >
> > Peter,
> >
> > Can you pull this patch into your queue?
>
> Not in my inbox..

This patch is so simple, so i do not want to interrupt you..
Will resend soon.

Thanks,
T.Zhou