2016-11-18 13:34:59

by Rahul Krishnan

Subject: [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block

This patch fixes the following checkpath.pl warning
WARNING: braces {} are not necessary for single statement blocks

Fixed indentation error, noted by Dan Carpenter

Signed-off-by: Rahul Krishnan <[email protected]>
---
drivers/staging/greybus/sdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
index f60b458..66b37ea 100644
--- a/drivers/staging/greybus/sdio.c
+++ b/drivers/staging/greybus/sdio.c
@@ -192,7 +192,7 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
}

if (event & GB_SDIO_WP)
- host->read_only = true;
+ host->read_only = true;

if (state_changed) {
dev_info(mmc_dev(host->mmc), "card %s now event\n",
--
2.10.2

2016-11-18 14:15:51

by Johan Hovold

Subject: Re: [PATCHv2]: staging: Greybus: Remove unnecessary braces for single statement block

On Fri, Nov 18, 2016 at 07:04:20PM +0530, Rahul Krishnan wrote:
> This patch fixes the following checkpath.pl warning
> WARNING: braces {} are not necessary for single statement blocks
>
> Fixed indentation error, noted by Dan Carpenter
>
> Signed-off-by: Rahul Krishnan <[email protected]>
> ---
> drivers/staging/greybus/sdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/sdio.c b/drivers/staging/greybus/sdio.c
> index f60b458..66b37ea 100644
> --- a/drivers/staging/greybus/sdio.c
> +++ b/drivers/staging/greybus/sdio.c
> @@ -192,7 +192,7 @@ static int _gb_sdio_process_events(struct gb_sdio_host *host, u8 event)
> }
>
> if (event & GB_SDIO_WP)
> - host->read_only = true;
> + host->read_only = true;

You need to redo your original patch. This one instead looks like a
follow-up to your first revision (which actually removed the braces).

>
> if (state_changed) {
> dev_info(mmc_dev(host->mmc), "card %s now event\n",

Thanks,
Johan