2016-11-23 13:07:20

by Arnd Bergmann

Subject: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS

The new driver caused a rare randconfig failure:

drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0xc): undefined reference to `fb_sys_read'
drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0x10): undefined reference to `fb_sys_write'

This selects the respective helper module, like all other
such drivers do.

Fixes: 8992da44c680 ("auxdisplay: ht16k33: Driver for LED controller")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/auxdisplay/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
index a230ea797b92..b8bbfc64a1d1 100644
--- a/drivers/auxdisplay/Kconfig
+++ b/drivers/auxdisplay/Kconfig
@@ -131,6 +131,7 @@ config IMG_ASCII_LCD
config HT16K33
tristate "Holtek Ht16K33 LED controller with keyscan"
depends on FB && OF && I2C && INPUT
+ select FB_SYS_FOPS
select INPUT_MATRIXKMAP
select FB_BACKLIGHT
help
--
2.9.0

2016-11-25 07:51:16

by Robin van der Gracht

Subject: Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS

Hi Arnd,

On Wed, 23 Nov 2016 14:06:49 +0100
Arnd Bergmann <[email protected]> wrote:

> The new driver caused a rare randconfig failure:
>
> drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0xc): undefined reference to `fb_sys_read'
> drivers/auxdisplay/ht16k33.o:(.data.ht16k33_fb_ops+0x10): undefined reference to `fb_sys_write'
>
> This selects the respective helper module, like all other
> such drivers do.

Thanks for reporting this. You are right about the missing helper.
However, the fb_ops struct uses several helpers which are all missing.

static struct fb_ops ht16k33_fb_ops = {
.owner = THIS_MODULE,
.fb_read = fb_sys_read,
.fb_write = fb_sys_write,
.fb_fillrect = sys_fillrect,
.fb_copyarea = sys_copyarea,
.fb_imageblit = sys_imageblit,
.fb_mmap = ht16k33_mmap,
};

HT16K33 should also select:
FB_CFB_FILLRECT
FB_CFB_COPYAREA
FB_CFB_IMAGEBLIT

>
> Fixes: 8992da44c680 ("auxdisplay: ht16k33: Driver for LED controller")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/auxdisplay/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/auxdisplay/Kconfig b/drivers/auxdisplay/Kconfig
> index a230ea797b92..b8bbfc64a1d1 100644
> --- a/drivers/auxdisplay/Kconfig
> +++ b/drivers/auxdisplay/Kconfig
> @@ -131,6 +131,7 @@ config IMG_ASCII_LCD
> config HT16K33
> tristate "Holtek Ht16K33 LED controller with keyscan"
> depends on FB && OF && I2C && INPUT
> + select FB_SYS_FOPS
> select INPUT_MATRIXKMAP
> select FB_BACKLIGHT
> help

Regards,
Robin

2016-11-25 08:30:44

by Arnd Bergmann

Subject: Re: [PATCH] auxdisplay: ht16k33: select CONFIG_FB_SYS_FOPS

On Friday, November 25, 2016 8:50:04 AM CET Robin van der Gracht wrote:
>
> Thanks for reporting this. You are right about the missing helper.
> However, the fb_ops struct uses several helpers which are all missing.
>
> static struct fb_ops ht16k33_fb_ops = {
> .owner = THIS_MODULE,
> .fb_read = fb_sys_read,
> .fb_write = fb_sys_write,
> .fb_fillrect = sys_fillrect,
> .fb_copyarea = sys_copyarea,
> .fb_imageblit = sys_imageblit,
> .fb_mmap = ht16k33_mmap,
> };
>
> HT16K33 should also select:
> FB_CFB_FILLRECT
> FB_CFB_COPYAREA
> FB_CFB_IMAGEBLIT
>

Ah right. I had not run into those so far during randconfig
testing, probably because there is usually at least one other
framebuffer enabled that selects them.

Can you submit a patch to add all those?

Arnd