2016-12-08 16:12:03

by Quentin Lambert

Subject: [PATCH] staging: lustre: Fix variable type declaration after refactoring

A recent clean-up declared och_flags as a int rather than fmode_t. This
lead to the following sparse warning:

drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
fmode_t degrades to integer

This patch fixes this issue.

Fixes: 1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
Signed-off-by: Quentin Lambert <[email protected]>
---
drivers/staging/lustre/lustre/include/obd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -889,7 +889,7 @@ struct obd_client_handle {
struct md_open_data *och_mod;
struct lustre_handle och_lease_handle; /* open lock for lease */
__u32 och_magic;
- int och_flags;
+ fmode_t och_flags;
};

#define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed

2016-12-08 19:37:12

by Dan Carpenter

Subject: Re: [PATCH] staging: lustre: Fix variable type declaration after refactoring

On Thu, Dec 08, 2016 at 05:07:59PM +0100, Quentin Lambert wrote:
> A recent clean-up declared och_flags as a int rather than fmode_t. This
> lead to the following sparse warning:
>
> drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
> fmode_t degrades to integer
>
> This patch fixes this issue.
>
> Fixes: 1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
0a1200991234f7

Fixes hash is wrong. It should start with "0a".

regards,
dan carpenter

2016-12-08 20:42:25

by Quentin Lambert

Subject: [PATCH v2] staging: lustre: Fix variable type declaration after refactoring

A recent clean-up declared och_flags as a int rather than fmode_t. This
lead to the following sparse warning:

drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
fmode_t degrades to integer

This patch fixes this issue.

Fixes: 0a1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
Signed-off-by: Quentin Lambert <[email protected]>
---
v2: fixes the referenced sha

drivers/staging/lustre/lustre/include/obd.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/lustre/lustre/include/obd.h
+++ b/drivers/staging/lustre/lustre/include/obd.h
@@ -889,7 +889,7 @@ struct obd_client_handle {
struct md_open_data *och_mod;
struct lustre_handle och_lease_handle; /* open lock for lease */
__u32 och_magic;
- int och_flags;
+ fmode_t och_flags;
};

#define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed

2016-12-19 16:38:50

by James Simmons

Subject: Re: [PATCH v2] staging: lustre: Fix variable type declaration after refactoring

> A recent clean-up declared och_flags as a int rather than fmode_t. This
> lead to the following sparse warning:
>
> drivers/staging/lustre/lustre/llite/file.c:106:30: warning: restricted
> fmode_t degrades to integer
>
> This patch fixes this issue.

Acked-by: James Simmons <[email protected]>

> Fixes: 0a1200991234f7 ("staging: lustre: cleanup lustre_lib.h")
> Signed-off-by: Quentin Lambert <[email protected]>
> ---
> v2: fixes the referenced sha
>
> drivers/staging/lustre/lustre/include/obd.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/staging/lustre/lustre/include/obd.h
> +++ b/drivers/staging/lustre/lustre/include/obd.h
> @@ -889,7 +889,7 @@ struct obd_client_handle {
> struct md_open_data *och_mod;
> struct lustre_handle och_lease_handle; /* open lock for lease */
> __u32 och_magic;
> - int och_flags;
> + fmode_t och_flags;
> };
>
> #define OBD_CLIENT_HANDLE_MAGIC 0xd15ea5ed
>