2016-12-15 19:49:09

by Corentin Labbe

Subject: [PATCH] sbus: char: Move D7S_MINOR to include/linux/miscdevice.h

This patch move the define for D7S_MINOR to include/linux/miscdevice.h.
It's better that all minor number are in the same place.

Signed-off-by: Corentin Labbe <[email protected]>
---
drivers/sbus/char/display7seg.c | 1 -
include/linux/miscdevice.h | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c
index 33fbe82..48a5df0 100644
--- a/drivers/sbus/char/display7seg.c
+++ b/drivers/sbus/char/display7seg.c
@@ -22,7 +22,6 @@

#include <asm/display7seg.h>

-#define D7S_MINOR 193
#define DRIVER_NAME "d7s"
#define PFX DRIVER_NAME ": "

diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
index 5385d95..b1ba37aef 100644
--- a/include/linux/miscdevice.h
+++ b/include/linux/miscdevice.h
@@ -33,6 +33,7 @@
#define I2O_MINOR 166
#define HWRNG_MINOR 183
#define MICROCODE_MINOR 184
+#define D7S_MINOR 193
#define VFIO_MINOR 196
#define TUN_MINOR 200
#define CUSE_MINOR 203
--
2.10.2

2016-12-17 01:06:36

by Julian Calaby

Subject: Re: [PATCH] sbus: char: Move D7S_MINOR to include/linux/miscdevice.h

Hi Corentin,

On Fri, Dec 16, 2016 at 6:47 AM, Corentin Labbe
<[email protected]> wrote:
> This patch move the define for D7S_MINOR to include/linux/miscdevice.h.
> It's better that all minor number are in the same place.
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> drivers/sbus/char/display7seg.c | 1 -
> include/linux/miscdevice.h | 1 +
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/sbus/char/display7seg.c b/drivers/sbus/char/display7seg.c
> index 33fbe82..48a5df0 100644
> --- a/drivers/sbus/char/display7seg.c
> +++ b/drivers/sbus/char/display7seg.c
> @@ -22,7 +22,6 @@
>
> #include <asm/display7seg.h>
>
> -#define D7S_MINOR 193
> #define DRIVER_NAME "d7s"
> #define PFX DRIVER_NAME ": "
>
> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
> index 5385d95..b1ba37aef 100644
> --- a/include/linux/miscdevice.h
> +++ b/include/linux/miscdevice.h
> @@ -33,6 +33,7 @@
> #define I2O_MINOR 166
> #define HWRNG_MINOR 183
> #define MICROCODE_MINOR 184
> +#define D7S_MINOR 193

I was going to say "why not change the name to something more
descriptive" however they're all very abbreviated, so maybe consider a
second patch series to describe what each of these is for?

> #define VFIO_MINOR 196
> #define TUN_MINOR 200
> #define CUSE_MINOR 203

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/