2016-12-24 07:33:16

by Rahul Krishnan

Subject: [PATCH] pci: hotplug: This patch removes unnecessary return statement using spatch tool

This patch removes unnecessary return statement using spatch tool

Signed-off-by: Rahul Krishnan <[email protected]>
---
drivers/pci/hotplug/rpadlpar_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
index dc67f39..9d0e2e1 100644
--- a/drivers/pci/hotplug/rpadlpar_core.c
+++ b/drivers/pci/hotplug/rpadlpar_core.c
@@ -463,8 +463,7 @@ int __init rpadlpar_io_init(void)
return -EPERM;
}

- rc = dlpar_sysfs_init();
- return rc;
+ return dlpar_sysfs_init();
}

void rpadlpar_io_exit(void)
--
2.7.4

2016-12-24 07:49:46

by Joe Perches

Subject: Re: [PATCH] pci: hotplug: This patch removes unnecessary return statement using spatch tool

On Sat, 2016-12-24 at 13:03 +0530, Rahul Krishnan wrote:
> This patch removes unnecessary return statement using spatch tool
[]
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
[]
> @@ -463,8 +463,7 @@ int __init rpadlpar_io_init(void)
> return -EPERM;
> }
>
> - rc = dlpar_sysfs_init();
> - return rc;
> + return dlpar_sysfs_init();
> }
>
> void rpadlpar_io_exit(void)

If you are going to submit these types
of patches, please make sure you compile
test them before sending so that you can
look at new warnings.

Now rc is unused and its declaration
should be removed.