2017-03-08 12:38:30

by Jaehoon Chung

Subject: [PATCH] phy: phy-exynos-pcie: fix the wrong error return

When it doesn't get the blk_base's resource, it was returned
the error about phy_base, not blk_base.
This patch is for fixing the wrong error return about blk_base.

Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY")

Signed-off-by: Jaehoon Chung <[email protected]>
---
drivers/phy/phy-exynos-pcie.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/phy-exynos-pcie.c b/drivers/phy/phy-exynos-pcie.c
index 4f60b83..60baf25 100644
--- a/drivers/phy/phy-exynos-pcie.c
+++ b/drivers/phy/phy-exynos-pcie.c
@@ -254,8 +254,8 @@ static int exynos_pcie_phy_probe(struct platform_device *pdev)

res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
exynos_phy->blk_base = devm_ioremap_resource(dev, res);
- if (IS_ERR(exynos_phy->phy_base))
- return PTR_ERR(exynos_phy->phy_base);
+ if (IS_ERR(exynos_phy->blk_base))
+ return PTR_ERR(exynos_phy->blk_base);

exynos_phy->drv_data = drv_data;

--
2.10.2

2017-03-09 08:14:01

by Kishon Vijay Abraham I

Subject: Re: [PATCH] phy: phy-exynos-pcie: fix the wrong error return

On Wednesday 08 March 2017 01:52 PM, Jaehoon Chung wrote:
> When it doesn't get the blk_base's resource, it was returned
> the error about phy_base, not blk_base.
> This patch is for fixing the wrong error return about blk_base.
>
> Fixes: cf0adb8e281b ("phy: phy-exynos-pcie: Add support for Exynos PCIe PHY")
>
> Signed-off-by: Jaehoon Chung <[email protected]>

merged, thanks.

-Kishon
> ---
> drivers/phy/phy-exynos-pcie.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/phy-exynos-pcie.c b/drivers/phy/phy-exynos-pcie.c
> index 4f60b83..60baf25 100644
> --- a/drivers/phy/phy-exynos-pcie.c
> +++ b/drivers/phy/phy-exynos-pcie.c
> @@ -254,8 +254,8 @@ static int exynos_pcie_phy_probe(struct platform_device *pdev)
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> exynos_phy->blk_base = devm_ioremap_resource(dev, res);
> - if (IS_ERR(exynos_phy->phy_base))
> - return PTR_ERR(exynos_phy->phy_base);
> + if (IS_ERR(exynos_phy->blk_base))
> + return PTR_ERR(exynos_phy->blk_base);
>
> exynos_phy->drv_data = drv_data;
>
>