2017-03-08 13:29:44

by SF Markus Elfring

Subject: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in ocrdma_alloc_mr()

From: Markus Elfring <[email protected]>
Date: Wed, 8 Mar 2017 10:00:41 +0100

Delete an assignment for the local variable "status" in an if branch
because the desired failure indication is already specified by a constant
error code at the end.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index 05d55d361cfe..af8798fd35b1 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -3031,10 +3031,8 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd,
return ERR_PTR(-ENOMEM);

mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL);
- if (!mr->pages) {
- status = -ENOMEM;
+ if (!mr->pages)
goto pl_err;
- }

status = ocrdma_get_pbl_info(dev, mr, max_num_sg);
if (status)
--
2.12.0

2017-03-08 15:42:48

by Devesh Sharma

Subject: Re: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in ocrdma_alloc_mr()

Acked-By: Devesh Sharma <[email protected]>

On Wed, Mar 8, 2017 at 6:52 PM, SF Markus Elfring
<[email protected]> wrote:
> From: Markus Elfring <[email protected]>
> Date: Wed, 8 Mar 2017 10:00:41 +0100
>
> Delete an assignment for the local variable "status" in an if branch
> because the desired failure indication is already specified by a constant
> error code at the end.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index 05d55d361cfe..af8798fd35b1 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -3031,10 +3031,8 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd,
> return ERR_PTR(-ENOMEM);
>
> mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL);
> - if (!mr->pages) {
> - status = -ENOMEM;
> + if (!mr->pages)
> goto pl_err;
> - }
>
> status = ocrdma_get_pbl_info(dev, mr, max_num_sg);
> if (status)
> --
> 2.12.0
>

2017-03-09 11:59:35

by Yuval Shaia

Subject: Re: [PATCH 20/26] IB/ocrdma: Delete an unnecessary variable assignment in ocrdma_alloc_mr()

On Wed, Mar 08, 2017 at 02:22:21PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Wed, 8 Mar 2017 10:00:41 +0100
>
> Delete an assignment for the local variable "status" in an if branch
> because the desired failure indication is already specified by a constant
> error code at the end.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index 05d55d361cfe..af8798fd35b1 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -3031,10 +3031,8 @@ struct ib_mr *ocrdma_alloc_mr(struct ib_pd *ibpd,
> return ERR_PTR(-ENOMEM);
>
> mr->pages = kcalloc(max_num_sg, sizeof(*mr->pages), GFP_KERNEL);
> - if (!mr->pages) {
> - status = -ENOMEM;
> + if (!mr->pages)
> goto pl_err;
> - }
>

Reviewed-by: Yuval Shaia <[email protected]>

> status = ocrdma_get_pbl_info(dev, mr, max_num_sg);
> if (status)
> --
> 2.12.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html