2017-03-08 13:28:09

by SF Markus Elfring

Subject: [PATCH 22/26] IB/ocrdma: Returning only value constants in ocrdma_resize_cq()

From: Markus Elfring <[email protected]>
Date: Wed, 8 Mar 2017 10:48:24 +0100

Return constant integer values without storing them in the local
variable "status".

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
index bedc229be89d..1d25512416f5 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
@@ -1123,15 +1123,12 @@ struct ib_cq *ocrdma_create_cq(struct ib_device *ibdev,
int ocrdma_resize_cq(struct ib_cq *ibcq, int new_cnt,
struct ib_udata *udata)
{
- int status = 0;
struct ocrdma_cq *cq = get_ocrdma_cq(ibcq);

- if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) {
- status = -EINVAL;
- return status;
- }
+ if (new_cnt < 1 || new_cnt > cq->max_hw_cqe)
+ return -EINVAL;
ibcq->cqe = new_cnt;
- return status;
+ return 0;
}

static void ocrdma_flush_cq(struct ocrdma_cq *cq)
--
2.12.0

2017-03-08 15:17:48

by Devesh Sharma

Subject: Re: [PATCH 22/26] IB/ocrdma: Returning only value constants in ocrdma_resize_cq()

Acked-By:Devesh Sharma <[email protected]>

On Wed, Mar 8, 2017 at 6:56 PM, SF Markus Elfring
<[email protected]> wrote:
> From: Markus Elfring <[email protected]>
> Date: Wed, 8 Mar 2017 10:48:24 +0100
>
> Return constant integer values without storing them in the local
> variable "status".
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index bedc229be89d..1d25512416f5 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -1123,15 +1123,12 @@ struct ib_cq *ocrdma_create_cq(struct ib_device *ibdev,
> int ocrdma_resize_cq(struct ib_cq *ibcq, int new_cnt,
> struct ib_udata *udata)
> {
> - int status = 0;
> struct ocrdma_cq *cq = get_ocrdma_cq(ibcq);
>
> - if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) {
> - status = -EINVAL;
> - return status;
> - }
> + if (new_cnt < 1 || new_cnt > cq->max_hw_cqe)
> + return -EINVAL;
> ibcq->cqe = new_cnt;
> - return status;
> + return 0;
> }
>
> static void ocrdma_flush_cq(struct ocrdma_cq *cq)
> --
> 2.12.0
>

2017-03-09 12:03:45

by Yuval Shaia

Subject: Re: [PATCH 22/26] IB/ocrdma: Returning only value constants in ocrdma_resize_cq()

On Wed, Mar 08, 2017 at 02:26:16PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <[email protected]>
> Date: Wed, 8 Mar 2017 10:48:24 +0100
>
> Return constant integer values without storing them in the local
> variable "status".
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> index bedc229be89d..1d25512416f5 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c
> @@ -1123,15 +1123,12 @@ struct ib_cq *ocrdma_create_cq(struct ib_device *ibdev,
> int ocrdma_resize_cq(struct ib_cq *ibcq, int new_cnt,
> struct ib_udata *udata)
> {
> - int status = 0;
> struct ocrdma_cq *cq = get_ocrdma_cq(ibcq);
>
> - if (new_cnt < 1 || new_cnt > cq->max_hw_cqe) {
> - status = -EINVAL;
> - return status;
> - }
> + if (new_cnt < 1 || new_cnt > cq->max_hw_cqe)
> + return -EINVAL;
> ibcq->cqe = new_cnt;
> - return status;
> + return 0;

Reviewed-by: Yuval Shaia <[email protected]>

> }
>
> static void ocrdma_flush_cq(struct ocrdma_cq *cq)
> --
> 2.12.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html