On Mon, Feb 06, 2017 at 11:35:29PM +0800, Wei Yang wrote:
> numa_nodemask_from_meminfo() is called to set bit according to
> numa_meminfo. While the only two places for this call is used to set proper
> bit to a copy of numa_nodes_parsed from numa_meminfo. With current code
> path, those numa node information in numa_meminfo is a subset of
> numa_nodes_parsed. So it is not necessary to set the bits again.
>
> The following is a code path analysis to prove the numa node information in
> numa_meminfo is a subset of numa_nodes_parsed.
>
> x86_numa_init()
> numa_init()
> Case 1
> acpi_numa_init()
> acpi_parse_memory_affinity()
> numa_add_memblk()
> node_set(numa_nodes_parsed)
> acpi_parse_slit()
> numa_nodemask_from_meminfo()
>
> Case 2
> amd_numa_init()
> numa_add_memblk()
> node_set(numa_nodes_parsed)
>
> Case 3
> dummy_numa_init()
> node_set(numa_nodes_parsed)
> numa_add_memblk()
>
> numa_register_memblks()
> numa_nodemask_from_meminfo()
What about of_numa_parse_memory_nodes() ?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
On Mon, Mar 13, 2017 at 02:30:46PM +0100, Borislav Petkov wrote:
>On Mon, Feb 06, 2017 at 11:35:29PM +0800, Wei Yang wrote:
>> numa_nodemask_from_meminfo() is called to set bit according to
>> numa_meminfo. While the only two places for this call is used to set proper
>> bit to a copy of numa_nodes_parsed from numa_meminfo. With current code
>> path, those numa node information in numa_meminfo is a subset of
>> numa_nodes_parsed. So it is not necessary to set the bits again.
>>
>> The following is a code path analysis to prove the numa node information in
>> numa_meminfo is a subset of numa_nodes_parsed.
>>
>> x86_numa_init()
>> numa_init()
>> Case 1
>> acpi_numa_init()
>> acpi_parse_memory_affinity()
>> numa_add_memblk()
>> node_set(numa_nodes_parsed)
>> acpi_parse_slit()
>> numa_nodemask_from_meminfo()
>>
>> Case 2
>> amd_numa_init()
>> numa_add_memblk()
>> node_set(numa_nodes_parsed)
>>
>> Case 3
>> dummy_numa_init()
>> node_set(numa_nodes_parsed)
>> numa_add_memblk()
>>
>> numa_register_memblks()
>> numa_nodemask_from_meminfo()
>
>What about of_numa_parse_memory_nodes() ?
>
Hi, Borislav
Glad to see your comment.
Here is the only place who will invoke of_numa_parse_memory_nodes()
arm64_numa_init()
of_numa_init()
of_numa_parse_memory_nodes()
So this is an arm64 specific function.
In this patch, these numa_nodemask_from_meminfo only affects x86.
>--
>Regards/Gruss,
> Boris.
>
>Good mailing practices for 400: avoid top-posting and trim the reply.
--
Wei Yang
Help you, Help me