2017-03-21 12:20:05

by Jaehoon Chung

[permalink] [raw]
Subject: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

There are same conditions for checking whether supporting clkscaling or
not.
When ufshcd is supporting clkscaling, active_reqs should be decreased by
two.

Signed-off-by: Jaehoon Chung <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dc6efbd..f2cbc71 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4598,8 +4598,6 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba,
}
if (ufshcd_is_clkscaling_supported(hba))
hba->clk_scaling.active_reqs--;
- if (ufshcd_is_clkscaling_supported(hba))
- hba->clk_scaling.active_reqs--;
}

/* clear corresponding bits of completed commands */
--
2.10.2


Subject: Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling


Hi,

On Tuesday, March 21, 2017 09:19:57 PM Jaehoon Chung wrote:
> There are same conditions for checking whether supporting clkscaling or
> not.
> When ufshcd is supporting clkscaling, active_reqs should be decreased by
> two.

I guess you meant "one" here, not "two"?

> Signed-off-by: Jaehoon Chung <[email protected]>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index dc6efbd..f2cbc71 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4598,8 +4598,6 @@ static void __ufshcd_transfer_req_compl(struct ufs_hba *hba,
> }
> if (ufshcd_is_clkscaling_supported(hba))
> hba->clk_scaling.active_reqs--;
> - if (ufshcd_is_clkscaling_supported(hba))
> - hba->clk_scaling.active_reqs--;
> }
>
> /* clear corresponding bits of completed commands */

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

2017-03-24 23:19:18

by Subhash Jadavani

[permalink] [raw]
Subject: Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

On 2017-03-21 05:19, Jaehoon Chung wrote:
> There are same conditions for checking whether supporting clkscaling or
> not.
> When ufshcd is supporting clkscaling, active_reqs should be decreased
> by
> two.
>
> Signed-off-by: Jaehoon Chung <[email protected]>
> ---
> drivers/scsi/ufs/ufshcd.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index dc6efbd..f2cbc71 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4598,8 +4598,6 @@ static void __ufshcd_transfer_req_compl(struct
> ufs_hba *hba,
> }
> if (ufshcd_is_clkscaling_supported(hba))
> hba->clk_scaling.active_reqs--;
> - if (ufshcd_is_clkscaling_supported(hba))
> - hba->clk_scaling.active_reqs--;
> }
>
> /* clear corresponding bits of completed commands */

Looks good to me.
Reviewed-by: Subhash Jadavani <[email protected]>

--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

2017-03-28 01:46:29

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH] scsi: ufs: remove the duplicated checking for supporting clkscaling

Jaehoon Chung <[email protected]> writes:

Jaehoon,

> There are same conditions for checking whether supporting clkscaling
> or not. When ufshcd is supporting clkscaling, active_reqs should be
> decreased by two.

Applied to 4.11/scsi-fixes.

Thank you!

--
Martin K. Petersen Oracle Linux Engineering