2017-04-04 13:39:44

by Tobias Regnery

[permalink] [raw]

Subject: [PATCH] IB/hns: include linux/of.h to fix build failure

---

I see the following build error in an arm64 randconfig build:

drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function 'hns_roce_v1_reset':
drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1384:15: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration]

Fix this by including linux/of.h directly.

Signed-off-by: Tobias Regnery <[email protected]>
---
This is against next-20170404

drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
index ec68f56e8ee5..0f7e85c7b70b 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
@@ -33,6 +33,7 @@
#include <linux/platform_device.h>
#include <linux/acpi.h>
#include <linux/etherdevice.h>
+#include <linux/of.h>
#include <rdma/ib_umem.h>
#include "hns_roce_common.h"
#include "hns_roce_device.h"
--
2.11.0

2017-04-05 21:24:12

by Doug Ledford

[permalink] [raw]

Subject: Re: [PATCH] IB/hns: include linux/of.h to fix build failure

---

On 4/4/2017 9:36 AM, Tobias Regnery wrote:
> I see the following build error in an arm64 randconfig build:
>
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c: In function 'hns_roce_v1_reset':
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1384:15: error: implicit declaration of function 'of_parse_phandle' [-Werror=implicit-function-declaration]
>
> Fix this by including linux/of.h directly.
>
> Signed-off-by: Tobias Regnery <[email protected]>
> ---
> This is against next-20170404
>
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> index ec68f56e8ee5..0f7e85c7b70b 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> @@ -33,6 +33,7 @@
> #include <linux/platform_device.h>
> #include <linux/acpi.h>
> #include <linux/etherdevice.h>
> +#include <linux/of.h>
> #include <rdma/ib_umem.h>
> #include "hns_roce_common.h"
> #include "hns_roce_device.h"
>

Hi Tobias, I already picked up this same change from another person.
Thanks.

--
Doug Ledford <[email protected]>
GPG Key ID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD

---

Attachments:

signature.asc (884.00 B)
OpenPGP digital signature