2017-04-04 19:15:22

by Thomas Jespersen

Subject: [PATCH] unisys: visornic: Replace symbolic perms with octal

Replace symbolic permissions S_IRUSR and S_IWUSR for their octal
counterparts

Signed-off-by: Thomas Jespersen <[email protected]>
---
drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c
index feece91..1008337 100644
--- a/drivers/staging/unisys/visornic/visornic_main.c
+++ b/drivers/staging/unisys/visornic/visornic_main.c
@@ -2146,11 +2146,11 @@ static int visornic_init(void)
if (!visornic_debugfs_dir)
return err;

- ret = debugfs_create_file("info", S_IRUSR, visornic_debugfs_dir, NULL,
+ ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
&debugfs_info_fops);
if (!ret)
goto cleanup_debugfs;
- ret = debugfs_create_file("enable_ints", S_IWUSR, visornic_debugfs_dir,
+ ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir,
NULL, &debugfs_enable_ints_fops);
if (!ret)
goto cleanup_debugfs;
--
2.10.2

2017-04-05 12:45:18

by Kershner, David A

Subject: RE: [PATCH] unisys: visornic: Replace symbolic perms with octal

> -----Original Message-----
> From: Thomas Jespersen [mailto:[email protected]]
> Sent: Tuesday, April 4, 2017 3:15 PM
> To: Kershner, David A <[email protected]>
> Cc: [email protected]; Sell, Timothy C
> <[email protected]>; Binder, David Anthony
> <[email protected]>; Frisch, Jon <[email protected]>;
> [email protected]; *S-Par-Maintainer
> <[email protected]>; [email protected]; linux-
> [email protected]
> Subject: [PATCH] unisys: visornic: Replace symbolic perms with octal
>

Should the subject line say "staging: unisys: visornic" instead of just
"unisys: visornic:"?

Besides that, I'm fine with this patch and have tested it on s-Par.

David Kershner

> Replace symbolic permissions S_IRUSR and S_IWUSR for their octal
> counterparts
>
> Signed-off-by: Thomas Jespersen <[email protected]>
> ---
> drivers/staging/unisys/visornic/visornic_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/unisys/visornic/visornic_main.c
> b/drivers/staging/unisys/visornic/visornic_main.c
> index feece91..1008337 100644
> --- a/drivers/staging/unisys/visornic/visornic_main.c
> +++ b/drivers/staging/unisys/visornic/visornic_main.c
> @@ -2146,11 +2146,11 @@ static int visornic_init(void)
> if (!visornic_debugfs_dir)
> return err;
>
> - ret = debugfs_create_file("info", S_IRUSR, visornic_debugfs_dir,
> NULL,
> + ret = debugfs_create_file("info", 0400, visornic_debugfs_dir, NULL,
> &debugfs_info_fops);
> if (!ret)
> goto cleanup_debugfs;
> - ret = debugfs_create_file("enable_ints", S_IWUSR,
> visornic_debugfs_dir,
> + ret = debugfs_create_file("enable_ints", 0200, visornic_debugfs_dir,
> NULL, &debugfs_enable_ints_fops);
> if (!ret)
> goto cleanup_debugfs;
> --
> 2.10.2