2017-06-02 13:03:57

by Guenter Roeck

Subject: Re: hexagon: Use raw_copy_to_user

ping ....

On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote:
> Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
> __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
> all callers, resulting in the following build error.
>
> arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
> arch/hexagon/mm/uaccess.c:40:3: error:
> implicit declaration of function '__copy_to_user_hexagon'
>
> Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
> Cc: Al Viro <[email protected]>
> Signed-off-by: Guenter Roeck <[email protected]>
> Acked-by: Al Viro <[email protected]>
> ---
> arch/hexagon/mm/uaccess.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c
> index ec90afdb3ad0..c599eb126c9e 100644
> --- a/arch/hexagon/mm/uaccess.c
> +++ b/arch/hexagon/mm/uaccess.c
> @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count)
> long uncleared;
>
> while (count > PAGE_SIZE) {
> - uncleared = __copy_to_user_hexagon(dest, &empty_zero_page,
> - PAGE_SIZE);
> + uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE);
> if (uncleared)
> return count - (PAGE_SIZE - uncleared);
> count -= PAGE_SIZE;
> dest += PAGE_SIZE;
> }
> if (count)
> - count = __copy_to_user_hexagon(dest, &empty_zero_page, count);
> + count = raw_copy_to_user(dest, &empty_zero_page, count);
>
> return count;
> }

2017-06-02 21:33:12

by Richard Kuo

Subject: Re: hexagon: Use raw_copy_to_user

On Fri, Jun 02, 2017 at 06:03:53AM -0700, Guenter Roeck wrote:
> ping ....
>
> On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote:
> > Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
> > __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
> > all callers, resulting in the following build error.
> >
> > arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
> > arch/hexagon/mm/uaccess.c:40:3: error:
> > implicit declaration of function '__copy_to_user_hexagon'
> >
> > Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
> > Cc: Al Viro <[email protected]>
> > Signed-off-by: Guenter Roeck <[email protected]>
> > Acked-by: Al Viro <[email protected]>
> > ---
> > arch/hexagon/mm/uaccess.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c
> > index ec90afdb3ad0..c599eb126c9e 100644
> > --- a/arch/hexagon/mm/uaccess.c
> > +++ b/arch/hexagon/mm/uaccess.c
> > @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count)
> > long uncleared;
> >
> > while (count > PAGE_SIZE) {
> > - uncleared = __copy_to_user_hexagon(dest, &empty_zero_page,
> > - PAGE_SIZE);
> > + uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE);
> > if (uncleared)
> > return count - (PAGE_SIZE - uncleared);
> > count -= PAGE_SIZE;
> > dest += PAGE_SIZE;
> > }
> > if (count)
> > - count = __copy_to_user_hexagon(dest, &empty_zero_page, count);
> > + count = raw_copy_to_user(dest, &empty_zero_page, count);
> >
> > return count;
> > }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html



Acked-by: Richard Kuo <[email protected]>


Thanks!



--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2017-06-02 22:45:53

by Guenter Roeck

Subject: Re: hexagon: Use raw_copy_to_user

Hi Richard,

On Fri, Jun 02, 2017 at 04:33:04PM -0500, Richard Kuo wrote:
> On Fri, Jun 02, 2017 at 06:03:53AM -0700, Guenter Roeck wrote:
> > ping ....
> >
> > On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote:
> > > Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
> > > __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
> > > all callers, resulting in the following build error.
> > >
> > > arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
> > > arch/hexagon/mm/uaccess.c:40:3: error:
> > > implicit declaration of function '__copy_to_user_hexagon'
> > >
> > > Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
> > > Cc: Al Viro <[email protected]>
> > > Signed-off-by: Guenter Roeck <[email protected]>
> > > Acked-by: Al Viro <[email protected]>
> > > ---
> > > arch/hexagon/mm/uaccess.c | 5 ++---
> > > 1 file changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c
> > > index ec90afdb3ad0..c599eb126c9e 100644
> > > --- a/arch/hexagon/mm/uaccess.c
> > > +++ b/arch/hexagon/mm/uaccess.c
> > > @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count)
> > > long uncleared;
> > >
> > > while (count > PAGE_SIZE) {
> > > - uncleared = __copy_to_user_hexagon(dest, &empty_zero_page,
> > > - PAGE_SIZE);
> > > + uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE);
> > > if (uncleared)
> > > return count - (PAGE_SIZE - uncleared);
> > > count -= PAGE_SIZE;
> > > dest += PAGE_SIZE;
> > > }
> > > if (count)
> > > - count = __copy_to_user_hexagon(dest, &empty_zero_page, count);
> > > + count = raw_copy_to_user(dest, &empty_zero_page, count);
> > >
> > > return count;
> > > }
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-hexagon" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Acked-by: Richard Kuo <[email protected]>
>
Do you want me to send it to Linus ?

Thanks,
Guenter