2017-06-03 17:39:14

by Vladimir Davydov

[permalink] [raw]
Subject: Re: [PATCH 3/6] mm: memcontrol: use the node-native slab memory counters

On Tue, May 30, 2017 at 02:17:21PM -0400, Johannes Weiner wrote:
> Now that the slab counters are moved from the zone to the node level
> we can drop the private memcg node stats and use the official ones.
>
> Signed-off-by: Johannes Weiner <[email protected]>
> ---
> include/linux/memcontrol.h | 2 --
> mm/memcontrol.c | 8 ++++----
> mm/slab.h | 4 ++--
> 3 files changed, 6 insertions(+), 8 deletions(-)

Not sure if moving slab stats from zone to node is such a good idea,
because they may be useful for identifying the reason of OOM, especially
on 32 bit hosts, but provided the previous patch is accepted, this one
looks good to me.

Acked-by: Vladimir Davydov <[email protected]>