2017-06-17 03:13:06

by Derek Robson

Subject: [PATCH V2] staging: unisys: visorhba - style fix

Fixed style of permissions to octal.
Found using checkpatch

Signed-off-by: Derek Robson <[email protected]>

V1 has vauge subject
---
drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c b/drivers/staging/unisys/visorhba/visorhba_main.c
index 2fd31c9762c6..a6e7a6bbc428 100644
--- a/drivers/staging/unisys/visorhba/visorhba_main.c
+++ b/drivers/staging/unisys/visorhba/visorhba_main.c
@@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
goto err_scsi_remove_host;
}
devdata->debugfs_info =
- debugfs_create_file("info", S_IRUSR | S_IRGRP,
+ debugfs_create_file("info", 0440,
devdata->debugfs_dir, devdata,
&info_debugfs_fops);
if (!devdata->debugfs_info) {
--
2.13.0

2017-06-19 15:28:30

by Kershner, David A

Subject: RE: [PATCH V2] staging: unisys: visorhba - style fix

> -----Original Message-----
> From: Derek Robson [mailto:[email protected]]
> Sent: Friday, June 16, 2017 11:13 PM
> To: Kershner, David A <[email protected]>;
> [email protected]; Sell, Timothy C <[email protected]>;
> Binder, David Anthony <[email protected]>; Wadgaonkar, Sameer
> Laxmikant <[email protected]>;
> [email protected]; [email protected]
> Cc: *S-Par-Maintainer <[email protected]>;
> [email protected]; [email protected]
> Subject: [PATCH V2] staging: unisys: visorhba - style fix
>
> Fixed style of permissions to octal.
> Found using checkpatch
>
> Signed-off-by: Derek Robson <[email protected]>

I applied it and tested it. Though when I applied it, the V1 comment was included in the patch commit.


>
> V1 has vauge subject
> ---
> drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> b/drivers/staging/unisys/visorhba/visorhba_main.c
> index 2fd31c9762c6..a6e7a6bbc428 100644
> --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
> goto err_scsi_remove_host;
> }
> devdata->debugfs_info =
> - debugfs_create_file("info", S_IRUSR | S_IRGRP,
> + debugfs_create_file("info", 0440,
> devdata->debugfs_dir, devdata,
> &info_debugfs_fops);
> if (!devdata->debugfs_info) {
> --
> 2.13.0

2017-06-19 22:01:35

by Tobin C. Harding

Subject: Re: [PATCH V2] staging: unisys: visorhba - style fix

On Mon, Jun 19, 2017 at 03:28:19PM +0000, Kershner, David A wrote:
>
> > -----Original Message-----
> > From: Derek Robson [mailto:[email protected]]
> > Sent: Friday, June 16, 2017 11:13 PM
> > To: Kershner, David A <[email protected]>;
> > [email protected]; Sell, Timothy C <[email protected]>;
> > Binder, David Anthony <[email protected]>; Wadgaonkar, Sameer
> > Laxmikant <[email protected]>;
> > [email protected]; [email protected]
> > Cc: *S-Par-Maintainer <[email protected]>;
> > [email protected]; [email protected]
> > Subject: [PATCH V2] staging: unisys: visorhba - style fix
> >
> > Fixed style of permissions to octal.
> > Found using checkpatch
> >
> > Signed-off-by: Derek Robson <[email protected]>
>
> I applied it and tested it. Though when I applied it, the V1 comment was included in the patch commit.

Derek, for clarification what David means is that the version notes
should go below the dotted line so as not to be included in the patch
commit. You may also like to read
Documentation/process/submitting-patches.rst for tips on writing your
commit log (specifically section 2).

>
>
> >
> > V1 has vauge subject
> > ---

v1 -> v2
- fix vague subject

> > drivers/staging/unisys/visorhba/visorhba_main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/unisys/visorhba/visorhba_main.c
> > b/drivers/staging/unisys/visorhba/visorhba_main.c
> > index 2fd31c9762c6..a6e7a6bbc428 100644
> > --- a/drivers/staging/unisys/visorhba/visorhba_main.c
> > +++ b/drivers/staging/unisys/visorhba/visorhba_main.c
> > @@ -1090,7 +1090,7 @@ static int visorhba_probe(struct visor_device *dev)
> > goto err_scsi_remove_host;
> > }
> > devdata->debugfs_info =
> > - debugfs_create_file("info", S_IRUSR | S_IRGRP,
> > + debugfs_create_file("info", 0440,
> > devdata->debugfs_dir, devdata,
> > &info_debugfs_fops);
> > if (!devdata->debugfs_info) {
> > --
> > 2.13.0
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Good luck,
Tobin.