2017-06-27 15:36:43

by Benson Leung

[permalink] [raw]
Subject: Re: [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive at probe

Hi Thierry,

On Tue, Feb 14, 2017 at 08:58:01PM +0100, Thierry Escande wrote:
> From: Gwendal Grignou <[email protected]>
>
> When the EC is not responsive at probe, we try to get basic information
> (protocol to use) later on through cros_xfer_cmd() call.
> This patch makes sure there is no deadlock when re-probing the EC by
> replacing call to cros_xfer_cmd() with send_command() in the function
> cros_ec_get_host_command_version_mask(). Also, this patch adds the
> function header indicating it must be called protected.
>
> Signed-off-by: Gwendal Grignou <[email protected]>
> Signed-off-by: Thierry Escande <[email protected]>

Applied. Thanks again!

--
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
[email protected]
Chromium OS Project
[email protected]


Attachments:
(No filename) (808.00 B)
signature.asc (819.00 B)
Digital signature
Download all attachments