2017-07-06 08:55:42

by Corentin Labbe

[permalink] [raw]
Subject: [PATCH] ARM: sunxi: h3/h5: Correct emac register size

The datasheet said that emac register size is 0x1000 not 0x104

Signed-off-by: Corentin Labbe <[email protected]>
---
arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
index 716e7d668dec..5a57b67c9b77 100644
--- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
+++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
@@ -406,7 +406,7 @@
emac: ethernet@1c30000 {
compatible = "allwinner,sun8i-h3-emac";
syscon = <&syscon>;
- reg = <0x01c30000 0x104>;
+ reg = <0x01c30000 0x1000>;
interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "macirq";
resets = <&ccu RST_BUS_EMAC>;
--
2.13.0


2017-07-06 18:52:19

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] ARM: sunxi: h3/h5: Correct emac register size

On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> The datasheet said that emac register size is 0x1000 not 0x104
>
> Signed-off-by: Corentin Labbe <[email protected]>
> ---
> arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 716e7d668dec..5a57b67c9b77 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -406,7 +406,7 @@
> emac: ethernet@1c30000 {
> compatible = "allwinner,sun8i-h3-emac";
> syscon = <&syscon>;
> - reg = <0x01c30000 0x104>;
> + reg = <0x01c30000 0x1000>;

The size is actually 0x10000. I fixed it and applied.

The A64 DTSI has the same issue, can you send a patch for this one
too?

Thanks,
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachments:
(No filename) (942.00 B)
 signature.asc (801.00 B)
 Download all attachments

2017-07-06 19:05:55

by Corentin Labbe

[permalink] [raw]
Subject: Re: [PATCH] ARM: sunxi: h3/h5: Correct emac register size

On Thu, Jul 06, 2017 at 08:52:05PM +0200, Maxime Ripard wrote:
> On Thu, Jul 06, 2017 at 10:53:34AM +0200, Corentin Labbe wrote:
> > The datasheet said that emac register size is 0x1000 not 0x104
> >
> > Signed-off-by: Corentin Labbe <[email protected]>
> > ---
> > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > index 716e7d668dec..5a57b67c9b77 100644
> > --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> > @@ -406,7 +406,7 @@
> > emac: ethernet@1c30000 {
> > compatible = "allwinner,sun8i-h3-emac";
> > syscon = <&syscon>;
> > - reg = <0x01c30000 0x104>;
> > + reg = <0x01c30000 0x1000>;
>
> The size is actually 0x10000. I fixed it and applied.
>
> The A64 DTSI has the same issue, can you send a patch for this one
> too?
>

Yes
Thanks for the fixing
Regards
Corentin Labbe