2017-07-10 03:26:07

by Gustavo A. R. Silva

Subject: [PATCH] usb: gadget: udc-xilinx: compress return logic into one line

Simplify return logic to avoid unnecessary variable assignment.

This issue was detected using Coccinelle and the following
semantic patch:

@@
local idexpression ret;
expression e;
@@

-ret =
+return
e;
-return ret;

Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
drivers/usb/gadget/udc/udc-xilinx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
index de207a9..552389d 100644
--- a/drivers/usb/gadget/udc/udc-xilinx.c
+++ b/drivers/usb/gadget/udc/udc-xilinx.c
@@ -1217,14 +1217,13 @@ static const struct usb_ep_ops xusb_ep_ops = {
static int xudc_get_frame(struct usb_gadget *gadget)
{
struct xusb_udc *udc;
- int frame;

if (!gadget)
return -ENODEV;

udc = to_udc(gadget);
- frame = udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET);
- return frame;
+
+ return udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET);
}

/**
--
2.5.0

2017-07-10 06:33:16

by Michal Simek

Subject: Re: [PATCH] usb: gadget: udc-xilinx: compress return logic into one line

On 10.7.2017 05:04, Gustavo A. R. Silva wrote:
> Simplify return logic to avoid unnecessary variable assignment.
>
> This issue was detected using Coccinelle and the following
> semantic patch:
>
> @@
> local idexpression ret;
> expression e;
> @@
>
> -ret =
> +return
> e;
> -return ret;
>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
> ---
> drivers/usb/gadget/udc/udc-xilinx.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c
> index de207a9..552389d 100644
> --- a/drivers/usb/gadget/udc/udc-xilinx.c
> +++ b/drivers/usb/gadget/udc/udc-xilinx.c
> @@ -1217,14 +1217,13 @@ static const struct usb_ep_ops xusb_ep_ops = {
> static int xudc_get_frame(struct usb_gadget *gadget)
> {
> struct xusb_udc *udc;
> - int frame;
>
> if (!gadget)
> return -ENODEV;
>
> udc = to_udc(gadget);
> - frame = udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET);
> - return frame;
> +
> + return udc->read_fn(udc->addr + XUSB_FRAMENUM_OFFSET);
> }
>
> /**
>

Acked-by: Michal Simek <[email protected]>

Thanks,
Michal