2017-07-10 18:51:07

by Colin King

Subject: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static

From: Colin Ian King <[email protected]>

Don't populate const array saa7128_regs_ntsc on the stack but insteaed make
it static. Makes the object code smaller and saves nearly 840 bytes

Before:
text data bss dec hex filename
9218 360 0 9578 256a solo6x10-tw28.o

After:
text data bss dec hex filename
8237 504 0 8741 2225 solo6x10-tw28.o

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/media/pci/solo6x10/solo6x10-tw28.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/pci/solo6x10/solo6x10-tw28.c b/drivers/media/pci/solo6x10/solo6x10-tw28.c
index 0632d3f7c73c..1c013a03d851 100644
--- a/drivers/media/pci/solo6x10/solo6x10-tw28.c
+++ b/drivers/media/pci/solo6x10/solo6x10-tw28.c
@@ -532,7 +532,7 @@ static void saa712x_write_regs(struct solo_dev *dev, const u8 *vals,
static void saa712x_setup(struct solo_dev *dev)
{
const int reg_start = 0x26;
- const u8 saa7128_regs_ntsc[] = {
+ static const u8 saa7128_regs_ntsc[] = {
/* :0x26 */
0x0d, 0x00,
/* :0x28 */
--
2.11.0

2017-07-11 17:54:23

by Andrey Utkin

Subject: Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static

On Mon, Jul 10, 2017 at 07:51:03PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Don't populate const array saa7128_regs_ntsc on the stack but insteaed make
> it static. Makes the object code smaller and saves nearly 840 bytes
>
> Before:
> text data bss dec hex filename
> 9218 360 0 9578 256a solo6x10-tw28.o
>
> After:
> text data bss dec hex filename
> 8237 504 0 8741 2225 solo6x10-tw28.o
>
> Signed-off-by: Colin Ian King <[email protected]>

Acked-by: Andrey Utkin <[email protected]>

2017-07-11 19:04:49

by Ismael Luceno

Subject: Re: [PATCH] [media] solo6x10: make const array saa7128_regs_ntsc static

On 10/Jul/2017 19:51, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> Don't populate const array saa7128_regs_ntsc on the stack but insteaed make
> it static. Makes the object code smaller and saves nearly 840 bytes
>
> Before:
> text data bss dec hex filename
> 9218 360 0 9578 256a solo6x10-tw28.o
>
> After:
> text data bss dec hex filename
> 8237 504 0 8741 2225 solo6x10-tw28.o
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/media/pci/solo6x10/solo6x10-tw28.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/solo6x10/solo6x10-tw28.c b/drivers/media/pci/solo6x10/solo6x10-tw28.c
> index 0632d3f7c73c..1c013a03d851 100644
> --- a/drivers/media/pci/solo6x10/solo6x10-tw28.c
> +++ b/drivers/media/pci/solo6x10/solo6x10-tw28.c
> @@ -532,7 +532,7 @@ static void saa712x_write_regs(struct solo_dev *dev, const u8 *vals,
> static void saa712x_setup(struct solo_dev *dev)
> {
> const int reg_start = 0x26;
> - const u8 saa7128_regs_ntsc[] = {
> + static const u8 saa7128_regs_ntsc[] = {
> /* :0x26 */
> 0x0d, 0x00,
> /* :0x28 */

Signed-off-by: Ismael Luceno <[email protected]>