2017-07-18 05:38:24

by hari prasath

Subject: [PATCH] staging: iio: adc: add space around substraction operation

Fix checkpatch warning to add space around the substraction operation

Signed-off-by: Hari Prasath <[email protected]>
---
drivers/staging/iio/adc/ad7280a.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
index d5ab83f..d79e774 100644
--- a/drivers/staging/iio/adc/ad7280a.c
+++ b/drivers/staging/iio/adc/ad7280a.c
@@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
}

static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
- in_voltage-voltage_thresh_low_value,
+ in_voltage - voltage_thresh_low_value,
0644,
ad7280_read_channel_config,
ad7280_write_channel_config,
AD7280A_CELL_UNDERVOLTAGE);

static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
- in_voltage-voltage_thresh_high_value,
+ in_voltage - voltage_thresh_high_value,
0644,
ad7280_read_channel_config,
ad7280_write_channel_config,
--
2.10.0.GIT

2017-07-18 05:57:25

by Jonathan Cameron

Subject: Re: [PATCH] staging: iio: adc: add space around substraction operation

On 18 July 2017 06:38:08 BST, Hari Prasath <[email protected]> wrote:
>Fix checkpatch warning to add space around the substraction operation
>
>Signed-off-by: Hari Prasath <[email protected]>
>---
> drivers/staging/iio/adc/ad7280a.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/staging/iio/adc/ad7280a.c
>b/drivers/staging/iio/adc/ad7280a.c
>index d5ab83f..d79e774 100644
>--- a/drivers/staging/iio/adc/ad7280a.c
>+++ b/drivers/staging/iio/adc/ad7280a.c
>@@ -745,14 +745,14 @@ static irqreturn_t ad7280_event_handler(int irq,
>void *private)
> }
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_low_value,
>- in_voltage-voltage_thresh_low_value,
>+ in_voltage - voltage_thresh_low_value,
> 0644,
> ad7280_read_channel_config,
> ad7280_write_channel_config,
> AD7280A_CELL_UNDERVOLTAGE);
>
> static IIO_DEVICE_ATTR_NAMED(in_thresh_high_value,
>- in_voltage-voltage_thresh_high_value,
>+ in_voltage - voltage_thresh_high_value,
> 0644,
> ad7280_read_channel_config,
> ad7280_write_channel_config,

Check what this code actually does.
Using checkpatch gives suggestions of where
to look for issues; it is not always right!

This change breaks the userspace ABI.

Jonathan

Ps when ever I see a patch involving whitespace and this driver I know I am going to give roughly
this response having done so perhaps 10 times in the past!

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.