2017-06-27 11:42:22

by Arvind Yadav

Subject: [PATCH] crypto: sahara : make of_device_ids const.

of_device_ids are not supposed to change at runtime. All functions
working with of_device_ids provided by <linux/of.h> work with const
of_device_ids. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
9759 2736 8 12503 30d7 drivers/crypto/sahara.o

File size after constify:
text data bss dec hex filename
10367 2128 8 12503 30d7 drivers/crypto/sahara.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/crypto/sahara.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index 1d9ecd3..c2174ec 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -1382,7 +1382,7 @@ static void sahara_unregister_algs(struct sahara_dev *dev)
};
MODULE_DEVICE_TABLE(platform, sahara_platform_ids);

-static struct of_device_id sahara_dt_ids[] = {
+static const struct of_device_id sahara_dt_ids[] = {
{ .compatible = "fsl,imx53-sahara" },
{ .compatible = "fsl,imx27-sahara" },
{ /* sentinel */ }
--
1.9.1

2017-07-18 10:36:10

by Herbert Xu

Subject: Re: [PATCH] crypto: sahara : make of_device_ids const.

On Tue, Jun 27, 2017 at 05:11:23PM +0530, Arvind Yadav wrote:
> of_device_ids are not supposed to change at runtime. All functions
> working with of_device_ids provided by <linux/of.h> work with const
> of_device_ids. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 9759 2736 8 12503 30d7 drivers/crypto/sahara.o
>
> File size after constify:
> text data bss dec hex filename
> 10367 2128 8 12503 30d7 drivers/crypto/sahara.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Patch applied. Thanks.
--
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt