2017-07-18 23:31:48

by Frank Rowand

Subject: [PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node_get()

From: Frank Rowand <[email protected]>

Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error:
OF: ERROR: Bad of_node_put() on /soc/usb@f9a55000

The error will occur if the configuration is set to:
CONFIG_OF_OVERLAY y
CONFIG_OF_UNITTEST y
CONFIG_OF_DYNAMIC y
CONFIG_OF_RESOLVE y

If CONFIG_OF_DYNAMIC is enabled then of_node_release() detects an
attempt to release a node that is still attached to the device tree.

Signed-off-by: Frank Rowand <[email protected]>
---
drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
index 0bdfcdcbf7a5..bb626120296f 100644
--- a/drivers/usb/chipidea/ci_hdrc_msm.c
+++ b/drivers/usb/chipidea/ci_hdrc_msm.c
@@ -251,7 +251,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
if (ret)
goto err_mux;

- ulpi_node = of_find_node_by_name(pdev->dev.of_node, "ulpi");
+ ulpi_node = of_find_node_by_name(of_node_get(pdev->dev.of_node), "ulpi");
if (ulpi_node) {
phy_node = of_get_next_available_child(ulpi_node, NULL);
ci->hsic = of_device_is_compatible(phy_node, "qcom,usb-hsic-phy");
--
Frank Rowand <[email protected]>

2017-07-19 01:52:29

by Peter Chen

Subject: Re: [PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node_get()

On Tue, Jul 18, 2017 at 04:31:28PM -0700, [email protected] wrote:
> From: Frank Rowand <[email protected]>
>
> Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error:
> OF: ERROR: Bad of_node_put() on /soc/usb@f9a55000
>
> The error will occur if the configuration is set to:
> CONFIG_OF_OVERLAY y
> CONFIG_OF_UNITTEST y
> CONFIG_OF_DYNAMIC y
> CONFIG_OF_RESOLVE y
>
> If CONFIG_OF_DYNAMIC is enabled then of_node_release() detects an
> attempt to release a node that is still attached to the device tree.
>
> Signed-off-by: Frank Rowand <[email protected]>
> ---
> drivers/usb/chipidea/ci_hdrc_msm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 0bdfcdcbf7a5..bb626120296f 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> @@ -251,7 +251,7 @@ static int ci_hdrc_msm_probe(struct platform_device *pdev)
> if (ret)
> goto err_mux;
>
> - ulpi_node = of_find_node_by_name(pdev->dev.of_node, "ulpi");
> + ulpi_node = of_find_node_by_name(of_node_get(pdev->dev.of_node), "ulpi");
> if (ulpi_node) {
> phy_node = of_get_next_available_child(ulpi_node, NULL);
> ci->hsic = of_device_is_compatible(phy_node, "qcom,usb-hsic-phy");
> --

Applied, thanks.

--

Best Regards,
Peter Chen