2017-07-25 07:50:47

by Santosh Sivaraj

Subject: [PATCH] kselftest/timers: fix build failure

"message" parameter was not passed to ksft_exit_skip.

Signed-off-by: Santosh Sivaraj <[email protected]>
---
tools/testing/selftests/timers/freq-step.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/timers/freq-step.c b/tools/testing/selftests/timers/freq-step.c
index e8c6183..bda9744 100644
--- a/tools/testing/selftests/timers/freq-step.c
+++ b/tools/testing/selftests/timers/freq-step.c
@@ -231,7 +231,7 @@ static void init_test(void)

if (precision > MAX_PRECISION) {
printf("[SKIP]\n");
- ksft_exit_skip();
+ ksft_exit_skip("[SKIP]\n");
}

printf("[OK]\n");
--
2.9.4

2017-07-25 12:44:54

by Miroslav Lichvar

Subject: Re: [PATCH] kselftest/timers: fix build failure

On Tue, Jul 25, 2017 at 01:20:37PM +0530, Santosh Sivaraj wrote:
> "message" parameter was not passed to ksft_exit_skip.

It looks like this was a bad merge of 76739256 and 54f57baa, which
added the new parameter to ksft_exit_skip().

> @@ -231,7 +231,7 @@ static void init_test(void)
>
> if (precision > MAX_PRECISION) {
> printf("[SKIP]\n");
> - ksft_exit_skip();
> + ksft_exit_skip("[SKIP]\n");

To avoid printing "skip" multiple times, I'd suggest to change the
argument of ksft_exit_skip to NULL.

Thanks,

--
Miroslav Lichvar

2017-07-25 13:32:17

by Santosh Sivaraj

Subject: [PATCH v2] kselftest/timers: fix build failure

Pass missing parameter to ksft_exit_skip.

Signed-off-by: Santosh Sivaraj <[email protected]>
---
V2 update: Pass NULL as suggested by Miroslav Lichvar

tools/testing/selftests/timers/freq-step.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/timers/freq-step.c b/tools/testing/selftests/timers/freq-step.c
index e8c6183..deff065 100644
--- a/tools/testing/selftests/timers/freq-step.c
+++ b/tools/testing/selftests/timers/freq-step.c
@@ -231,7 +231,7 @@ static void init_test(void)

if (precision > MAX_PRECISION) {
printf("[SKIP]\n");
- ksft_exit_skip();
+ ksft_exit_skip(NULL);
}

printf("[OK]\n");
--
2.9.4