usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Arvind Yadav (3):
[PATCH 1/3] staging: most: usb: constify usb_device_id
[PATCH 2/3] staging: rtl8188eu: constify usb_device_id
[PATCH 3/3] staging: rtl8712: constify usb_device_id
drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
drivers/staging/rtl8712/usb_intf.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--
2.7.4
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c
index d0f68cb..a9c3785 100644
--- a/drivers/staging/most/hdm-usb/hdm_usb.c
+++ b/drivers/staging/most/hdm-usb/hdm_usb.c
@@ -832,7 +832,7 @@ static const struct file_operations hdm_usb_fops = {
/**
* usb_device_id - ID table for HCD device probing
*/
-static struct usb_device_id usbid[] = {
+static const struct usb_device_id usbid[] = {
{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_BRDG), },
{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81118), },
{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81119), },
--
2.7.4
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/staging/rtl8712/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
index 897d462..b3e266b 100644
--- a/drivers/staging/rtl8712/usb_intf.c
+++ b/drivers/staging/rtl8712/usb_intf.c
@@ -47,7 +47,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
static void r871xu_dev_remove(struct usb_interface *pusb_intf);
-static struct usb_device_id rtl871x_usb_id_tbl[] = {
+static const struct usb_device_id rtl871x_usb_id_tbl[] = {
/* RTL8188SU */
/* Realtek */
--
2.7.4
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 963235f..2ef71c3 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -32,7 +32,7 @@
#define USB_VENDER_ID_REALTEK 0x0bda
/* DID_USB_v916_20130116 */
-static struct usb_device_id rtw_usb_id_tbl[] = {
+static const struct usb_device_id rtw_usb_id_tbl[] = {
/*=== Realtek demoboard ===*/
{USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8179)}, /* 8188EUS */
{USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
--
2.7.4
On Tue, 8 Aug 2017 22:53:13 +0530
Arvind Yadav <[email protected]> wrote:
> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>
Acked-by: Christian Gromm <[email protected]>
> ---
> drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c
> b/drivers/staging/most/hdm-usb/hdm_usb.c index d0f68cb..a9c3785 100644
> --- a/drivers/staging/most/hdm-usb/hdm_usb.c
> +++ b/drivers/staging/most/hdm-usb/hdm_usb.c
> @@ -832,7 +832,7 @@ static const struct file_operations hdm_usb_fops
> = { /**
> * usb_device_id - ID table for HCD device probing
> */
> -static struct usb_device_id usbid[] = {
> +static const struct usb_device_id usbid[] = {
> { USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_BRDG), },
> { USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81118), },
> { USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81119), },
--
thanks,
Chris
Christian Gromm
Principal Software Engineer
Microchip Technology Germany II GmbH & Co. KG
Emmy-Noether-Straße 14
76131 Karlsruhe | Germany
Tel: +49 721 62537 466 | Fax: +49 721 62537 119
[email protected] | http://www.microchip.com
Firmensitz: Ismaning
Registergericht: Amtsgericht München, HRA 98692
Persönlich haftende Gesellschafterin: Microchip Technology Germany GmbH
mit Sitz in Ismaning Registergericht: München, HRB 197 653
Geschäftsführer: Mohammed Nawaz Sharif, James Eric Bjornholt, Norbert
Siedhoff
Diese E-Mail kann vertrauliche Informationen enthalten. Sie darf nicht
durch andere als die ursprünglich genannten Adressaten genutzt, kopiert
oder weitergeleitet werden. This e-mail may contain confidential
information and should not be used, copied or disclosed by anyone who
is not the original intended recipient.