2017-08-10 16:28:16

by Amitoj Kaur Chawla

[permalink] [raw]
Subject: [PATCH 2/2] leds: lm3533: constify attribute_group structure

Functions working with attribute_groups provided by <linux/device.h>
work with const attribute_group. These attribute_group structures do not
change at runtime so mark them as const.

File size before:
text data bss dec hex filename
8272 4608 64 12944 3290 drivers/leds/leds-lm3533.o

File size after:
text data bss dec hex filename
8368 4512 64 12944 3290 drivers/leds/leds-lm3533.o

This change was made with the help of Coccinelle.

Signed-off-by: Amitoj Kaur Chawla <[email protected]>
---
drivers/leds/leds-lm3533.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c
index 5b529dc..72224b5 100644
--- a/drivers/leds/leds-lm3533.c
+++ b/drivers/leds/leds-lm3533.c
@@ -626,7 +626,7 @@ static umode_t lm3533_led_attr_is_visible(struct kobject *kobj,
return mode;
};

-static struct attribute_group lm3533_led_attribute_group = {
+static const struct attribute_group lm3533_led_attribute_group = {
.is_visible = lm3533_led_attr_is_visible,
.attrs = lm3533_led_attributes
};
--
2.7.4


2017-08-11 12:34:41

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 2/2] leds: lm3533: constify attribute_group structure

On Thu 2017-08-10 12:28:09, Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/device.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
>
> File size before:
> text data bss dec hex filename
> 8272 4608 64 12944 3290 drivers/leds/leds-lm3533.o
>
> File size after:
> text data bss dec hex filename
> 8368 4512 64 12944 3290 drivers/leds/leds-lm3533.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <[email protected]>

patches 1,2:

Acked-by: Pavel Machek <[email protected]>

Pavel

> -static struct attribute_group lm3533_led_attribute_group = {
> +static const struct attribute_group lm3533_led_attribute_group = {
> .is_visible = lm3533_led_attr_is_visible,
> .attrs = lm3533_led_attributes
> };

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachments:
(No filename) (1.05 kB)
 signature.asc (181.00 B)
Digital signature Download all attachments

2017-08-14 20:47:07

by Jacek Anaszewski

[permalink] [raw]
Subject: Re: [PATCH 2/2] leds: lm3533: constify attribute_group structure

Hi Amitoj,

Thanks for the patch, applied.

Best regards,
Jacek Anaszewski

On 08/10/2017 06:28 PM, Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/device.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
>
> File size before:
> text data bss dec hex filename
> 8272 4608 64 12944 3290 drivers/leds/leds-lm3533.o
>
> File size after:
> text data bss dec hex filename
> 8368 4512 64 12944 3290 drivers/leds/leds-lm3533.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <[email protected]>
> ---
> drivers/leds/leds-lm3533.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c
> index 5b529dc..72224b5 100644
> --- a/drivers/leds/leds-lm3533.c
> +++ b/drivers/leds/leds-lm3533.c
> @@ -626,7 +626,7 @@ static umode_t lm3533_led_attr_is_visible(struct kobject *kobj,
> return mode;
> };
>
> -static struct attribute_group lm3533_led_attribute_group = {
> +static const struct attribute_group lm3533_led_attribute_group = {
> .is_visible = lm3533_led_attr_is_visible,
> .attrs = lm3533_led_attributes
> };
>