2017-08-17 17:34:57

by Arvind Yadav

Subject: [PATCH] tpm: vtpm: constify vio_device_id

vio_device_id are not supposed to change at runtime. All functions
working with vio_device_id provided by <asm/vio.h> work with
const vio_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
index f01d083..d2ce46b 100644
--- a/drivers/char/tpm/tpm_ibmvtpm.c
+++ b/drivers/char/tpm/tpm_ibmvtpm.c
@@ -32,7 +32,7 @@

static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm";

-static struct vio_device_id tpm_ibmvtpm_device_table[] = {
+static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
{ "IBM,vtpm", "IBM,vtpm"},
{ "", "" }
};
--
2.7.4

2017-08-17 19:16:57

by Jason Gunthorpe

Subject: Re: [PATCH] tpm: vtpm: constify vio_device_id

On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote:
> vio_device_id are not supposed to change at runtime. All functions
> working with vio_device_id provided by <asm/vio.h> work with
> const vio_device_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Reviewed-by: Jason Gunthorpe <[email protected]>

> drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm_ibmvtpm.c b/drivers/char/tpm/tpm_ibmvtpm.c
> index f01d083..d2ce46b 100644
> +++ b/drivers/char/tpm/tpm_ibmvtpm.c
> @@ -32,7 +32,7 @@
>
> static const char tpm_ibmvtpm_driver_name[] = "tpm_ibmvtpm";
>
> -static struct vio_device_id tpm_ibmvtpm_device_table[] = {
> +static const struct vio_device_id tpm_ibmvtpm_device_table[] = {
> { "IBM,vtpm", "IBM,vtpm"},
> { "", "" }
> };

2017-08-18 11:32:52

by Michael Ellerman

Subject: Re: [PATCH] tpm: vtpm: constify vio_device_id

Jason Gunthorpe <[email protected]> writes:

> On Thu, Aug 17, 2017 at 11:04:21PM +0530, Arvind Yadav wrote:
>> vio_device_id are not supposed to change at runtime. All functions
>> working with vio_device_id provided by <asm/vio.h> work with
>> const vio_device_id. So mark the non-const structs as const.
>>
>> Signed-off-by: Arvind Yadav <[email protected]>
>
> Reviewed-by: Jason Gunthorpe <[email protected]>

Thanks Jason.

>> drivers/char/tpm/tpm_ibmvtpm.c | 2 +-

Who merges changes for this driver? I assume it's Jarkko?

cheers

2017-08-18 20:32:10

by Jason Gunthorpe

Subject: Re: [PATCH] tpm: vtpm: constify vio_device_id

On Fri, Aug 18, 2017 at 09:32:46PM +1000, Michael Ellerman wrote:

> >> drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
>
> Who merges changes for this driver? I assume it's Jarkko?

Yes

Jason

2017-08-19 17:21:55

by Jarkko Sakkinen

Subject: Re: [PATCH] tpm: vtpm: constify vio_device_id

On Fri, Aug 18, 2017 at 02:31:56PM -0600, Jason Gunthorpe wrote:
> On Fri, Aug 18, 2017 at 09:32:46PM +1000, Michael Ellerman wrote:
>
> > >> drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
> >
> > Who merges changes for this driver? I assume it's Jarkko?
>
> Yes
>
> Jason

Applied.

/Jarkko

2017-08-23 14:06:10

by Michael Ellerman

Subject: Re: [PATCH] tpm: vtpm: constify vio_device_id

Jarkko Sakkinen <[email protected]> writes:

> On Fri, Aug 18, 2017 at 02:31:56PM -0600, Jason Gunthorpe wrote:
>> On Fri, Aug 18, 2017 at 09:32:46PM +1000, Michael Ellerman wrote:
>>
>> > >> drivers/char/tpm/tpm_ibmvtpm.c | 2 +-
>> >
>> > Who merges changes for this driver? I assume it's Jarkko?
>>
>> Yes
>>
>> Jason
>
> Applied.

Thanks.

cheers