2017-08-23 17:17:39

by Arvind Yadav

Subject: [PATCH] vfio: platform: constify amba_id

amba_id are not supposed to change at runtime. All functions
working with const amba_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/vfio/platform/vfio_amba.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vfio/platform/vfio_amba.c b/drivers/vfio/platform/vfio_amba.c
index 31372fb..62dfbfe 100644
--- a/drivers/vfio/platform/vfio_amba.c
+++ b/drivers/vfio/platform/vfio_amba.c
@@ -93,7 +93,7 @@ static int vfio_amba_remove(struct amba_device *adev)
return -EINVAL;
}

-static struct amba_id pl330_ids[] = {
+static const struct amba_id pl330_ids[] = {
{ 0, 0 },
};

--
2.7.4

2017-08-30 21:24:39

by Alex Williamson

Subject: Re: [PATCH] vfio: platform: constify amba_id

On Wed, 23 Aug 2017 22:47:15 +0530
Arvind Yadav <[email protected]> wrote:

> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/vfio/platform/vfio_amba.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vfio/platform/vfio_amba.c b/drivers/vfio/platform/vfio_amba.c
> index 31372fb..62dfbfe 100644
> --- a/drivers/vfio/platform/vfio_amba.c
> +++ b/drivers/vfio/platform/vfio_amba.c
> @@ -93,7 +93,7 @@ static int vfio_amba_remove(struct amba_device *adev)
> return -EINVAL;
> }
>
> -static struct amba_id pl330_ids[] = {
> +static const struct amba_id pl330_ids[] = {
> { 0, 0 },
> };
>

Applied to next branch for v4.14. Thanks,

Alex