2017-09-14 23:05:19

by Colin King

Subject: [PATCH] dma-buf: remove redundant initialization of sg_table

From: Colin Ian King <[email protected]>

sg_table is being initialized and is never read before it is updated
again later on, hence making the initialization redundant. Remove
the initialization.

Detected by clang scan-build:
"warning: Value stored to 'sg_table' during its initialization is
never read"

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/dma-buf/dma-buf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index 4a038dcf5361..bc1cb284111c 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -625,7 +625,7 @@ EXPORT_SYMBOL_GPL(dma_buf_detach);
struct sg_table *dma_buf_map_attachment(struct dma_buf_attachment *attach,
enum dma_data_direction direction)
{
- struct sg_table *sg_table = ERR_PTR(-EINVAL);
+ struct sg_table *sg_table;

might_sleep();

--
2.14.1

2017-09-15 08:48:56

by Chris Wilson

Subject: Re: [PATCH] dma-buf: remove redundant initialization of sg_table

Quoting Colin King (2017-09-15 00:05:16)
> From: Colin Ian King <[email protected]>
>
> sg_table is being initialized and is never read before it is updated
> again later on, hence making the initialization redundant. Remove
> the initialization.
>
> Detected by clang scan-build:
> "warning: Value stored to 'sg_table' during its initialization is
> never read"
>
> Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Chris Wilson <[email protected]>
-Chris