2017-09-19 10:18:23

by Markus Trippelsdorf

Subject: [PATCH] VFS: Handle lazytime in do_mount()

The lazytime option didn't get passed on when using current util-linux,
which passes MS_LAZYTIME in the mountflags directly.

Fix the issue by handling the option in do_mount().

Signed-off-by: Markus Trippelsdorf <[email protected]>
---
fs/namespace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index 54059b142d6b..b633838b8f02 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,
SB_MANDLOCK |
SB_DIRSYNC |
SB_SILENT |
- SB_POSIXACL);
+ SB_POSIXACL |
+ MS_LAZYTIME);

if (flags & MS_REMOUNT)
retval = do_remount(&path, flags, sb_flags, mnt_flags,
--
Markus

2017-09-19 10:37:27

by Markus Trippelsdorf

Subject: [PATCH v2] VFS: Handle lazytime in do_mount()

Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from
internal superblock flags") the lazytime mount option didn't get passed
on anymore.

Fix the issue by handling the option in do_mount().

Signed-off-by: Markus Trippelsdorf <[email protected]>
---
fs/namespace.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/namespace.c b/fs/namespace.c
index 54059b142d6b..b633838b8f02 100644
--- a/fs/namespace.c
+++ b/fs/namespace.c
@@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,
SB_MANDLOCK |
SB_DIRSYNC |
SB_SILENT |
- SB_POSIXACL);
+ SB_POSIXACL |
+ SB_LAZYTIME);

if (flags & MS_REMOUNT)
retval = do_remount(&path, flags, sb_flags, mnt_flags,
--
Markus

2017-09-19 15:25:06

by Lukas Czerner

Subject: Re: [PATCH v2] VFS: Handle lazytime in do_mount()

On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote:
> Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from
> internal superblock flags") the lazytime mount option didn't get passed
> on anymore.
>
> Fix the issue by handling the option in do_mount().
>
> Signed-off-by: Markus Trippelsdorf <[email protected]>
> ---
> fs/namespace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 54059b142d6b..b633838b8f02 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,
> SB_MANDLOCK |
> SB_DIRSYNC |
> SB_SILENT |
> - SB_POSIXACL);
> + SB_POSIXACL |
> + SB_LAZYTIME);

Looks good. Although I still think that this can be per mountpoint options.

Regardless of that, you can add
Reviewed-by: Lukas Czerner <[email protected]>

>
> if (flags & MS_REMOUNT)
> retval = do_remount(&path, flags, sb_flags, mnt_flags,
> --
> Markus

2017-09-30 07:10:27

by Markus Trippelsdorf

Subject: Re: [PATCH v2] VFS: Handle lazytime in do_mount()

On 2017.09.19 at 17:25 +0200, Lukas Czerner wrote:
> On Tue, Sep 19, 2017 at 12:37:24PM +0200, Markus Trippelsdorf wrote:
> > Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from
> > internal superblock flags") the lazytime mount option didn't get passed
> > on anymore.
> >
> > Fix the issue by handling the option in do_mount().
> >
> > Signed-off-by: Markus Trippelsdorf <[email protected]>
> > ---
> > fs/namespace.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/namespace.c b/fs/namespace.c
> > index 54059b142d6b..b633838b8f02 100644
> > --- a/fs/namespace.c
> > +++ b/fs/namespace.c
> > @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,
> > SB_MANDLOCK |
> > SB_DIRSYNC |
> > SB_SILENT |
> > - SB_POSIXACL);
> > + SB_POSIXACL |
> > + SB_LAZYTIME);
>
> Looks good. Although I still think that this can be per mountpoint options.
>
> Regardless of that, you can add
> Reviewed-by: Lukas Czerner <[email protected]>

Ping?
Al could you please take look?
Thanks.

--
Markus

2017-11-17 18:35:09

by Goldwyn Rodrigues

Subject: Re: [PATCH] VFS: Handle lazytime in do_mount()

On 10/11/2017 12:01 AM, Markus Trippelsdorf wrote:
> Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from
> internal superblock flags") the lazytime mount option doesn't get passed
> on anymore.
>
> Fix the issue by handling the option in do_mount().
>
> Reviewed-by: Lukas Czerner <[email protected]>
> Signed-off-by: Markus Trippelsdorf <[email protected]>

Reviewed-by: Goldwyn Rodrigues <[email protected]>

> ---
> fs/namespace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 54059b142d6b..b633838b8f02 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,
> SB_MANDLOCK |
> SB_DIRSYNC |
> SB_SILENT |
> - SB_POSIXACL);
> + SB_POSIXACL |
> + SB_LAZYTIME);
>
> if (flags & MS_REMOUNT)
> retval = do_remount(&path, flags, sb_flags, mnt_flags,
>

--
Goldwyn

From 1580936075669604190@xxx Wed Oct 11 05:02:11 +0000 2017
X-GM-THRID: 1580936075669604190
X-Gmail-Labels: Inbox,Category Forums