2017-09-19 14:58:13

by Dave Gerlach

Subject: [PATCH] cpufreq: dt-platdev: Add devices covered by ti-cpufreq to blacklist

Commit edeec420de24 ("cpufreq: dt-platdev: Automatically create cpufreq
device with OPP v2") causes a cpufreq-dt platform device to be
automatically created for any platform with an OPP v2 node defined.
However, ti-cpufreq registers the cpufreq-dt platdev at the end of probe
in order to ensure the ti-cpufreq driver probes first and provides the
necessary opp-supported-hw for cpufreq-dt. With this new patch now a
dupluicate cpufreq-dt is created, which we do not want. To avoid this,
add the platforms handled by ti-cpufreq to the blacklist provided in the
aforementioned commit to allow ti-cpufreq to continue creating the
cpufreq-dt platdev.

This applies to am335x, am437x, dra7xx, and am57xx.

Fixes: edeec420de24 ("cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2")
Signed-off-by: Dave Gerlach <[email protected]>
---
drivers/cpufreq/cpufreq-dt-platdev.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index a020da7940d6..c6f554ba9bb3 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -106,6 +106,10 @@ static const struct of_device_id whitelist[] __initconst = {
* platforms using "operating-points-v2" property.
*/
static const struct of_device_id blacklist[] __initconst = {
+ { .compatible = "ti,am33xx", },
+ { .compatible = "ti,am43", },
+ { .compatible = "ti,dra7", },
+
{ }
};

--
2.13.4

2017-09-19 15:02:22

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: dt-platdev: Add devices covered by ti-cpufreq to blacklist

On 19 September 2017 at 07:57, Dave Gerlach <[email protected]> wrote:
> Commit edeec420de24 ("cpufreq: dt-platdev: Automatically create cpufreq
> device with OPP v2") causes a cpufreq-dt platform device to be
> automatically created for any platform with an OPP v2 node defined.
> However, ti-cpufreq registers the cpufreq-dt platdev at the end of probe
> in order to ensure the ti-cpufreq driver probes first and provides the
> necessary opp-supported-hw for cpufreq-dt. With this new patch now a
> dupluicate cpufreq-dt is created, which we do not want. To avoid this,
> add the platforms handled by ti-cpufreq to the blacklist provided in the
> aforementioned commit to allow ti-cpufreq to continue creating the
> cpufreq-dt platdev.
>
> This applies to am335x, am437x, dra7xx, and am57xx.
>
> Fixes: edeec420de24 ("cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2")
> Signed-off-by: Dave Gerlach <[email protected]>
> ---
> drivers/cpufreq/cpufreq-dt-platdev.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index a020da7940d6..c6f554ba9bb3 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -106,6 +106,10 @@ static const struct of_device_id whitelist[] __initconst = {
> * platforms using "operating-points-v2" property.
> */
> static const struct of_device_id blacklist[] __initconst = {
> + { .compatible = "ti,am33xx", },
> + { .compatible = "ti,am43", },
> + { .compatible = "ti,dra7", },
> +
> { }
> };

Perhaps you should ask Sunil to improve his patch.

https://marc.info/?l=linux-kernel&m=150576233031387&w=2

2017-09-19 15:09:27

by Dave Gerlach

Subject: Re: [PATCH] cpufreq: dt-platdev: Add devices covered by ti-cpufreq to blacklist

On 09/19/2017 10:02 AM, Viresh Kumar wrote:
> On 19 September 2017 at 07:57, Dave Gerlach <[email protected]> wrote:
>> Commit edeec420de24 ("cpufreq: dt-platdev: Automatically create cpufreq
>> device with OPP v2") causes a cpufreq-dt platform device to be
>> automatically created for any platform with an OPP v2 node defined.
>> However, ti-cpufreq registers the cpufreq-dt platdev at the end of probe
>> in order to ensure the ti-cpufreq driver probes first and provides the
>> necessary opp-supported-hw for cpufreq-dt. With this new patch now a
>> dupluicate cpufreq-dt is created, which we do not want. To avoid this,
>> add the platforms handled by ti-cpufreq to the blacklist provided in the
>> aforementioned commit to allow ti-cpufreq to continue creating the
>> cpufreq-dt platdev.
>>
>> This applies to am335x, am437x, dra7xx, and am57xx.
>>
>> Fixes: edeec420de24 ("cpufreq: dt-cpufreq: platdev Automatically create device with OPP v2")
>> Signed-off-by: Dave Gerlach <[email protected]>
>> ---
>> drivers/cpufreq/cpufreq-dt-platdev.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
>> index a020da7940d6..c6f554ba9bb3 100644
>> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
>> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
>> @@ -106,6 +106,10 @@ static const struct of_device_id whitelist[] __initconst = {
>> * platforms using "operating-points-v2" property.
>> */
>> static const struct of_device_id blacklist[] __initconst = {
>> + { .compatible = "ti,am33xx", },
>> + { .compatible = "ti,am43", },
>> + { .compatible = "ti,dra7", },
>> +
>> { }
>> };
>
> Perhaps you should ask Sunil to improve his patch.
>
> https://marc.info/?l=linux-kernel&m=150576233031387&w=2
>

Ah, did not see that. Somebody added me to a thread last week about this and I
just got around to making a fix now, I will jump on to that thread thanks.

Regards,
Dave