2017-09-25 09:41:20

by Arvind Yadav

Subject: [PATCH] cpufreq: powernow-k8: pr_err() strings should end with newlines

pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/cpufreq/powernow-k8.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
index 062d714..b01e31d 100644
--- a/drivers/cpufreq/powernow-k8.c
+++ b/drivers/cpufreq/powernow-k8.c
@@ -1043,7 +1043,7 @@ static int powernowk8_cpu_init(struct cpufreq_policy *pol)

data = kzalloc(sizeof(*data), GFP_KERNEL);
if (!data) {
- pr_err("unable to alloc powernow_k8_data");
+ pr_err("unable to alloc powernow_k8_data\n");
return -ENOMEM;
}

--
1.9.1

2017-09-25 23:11:53

by Viresh Kumar

Subject: Re: [PATCH] cpufreq: powernow-k8: pr_err() strings should end with newlines

On 25-09-17, 15:10, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/cpufreq/powernow-k8.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
> index 062d714..b01e31d 100644
> --- a/drivers/cpufreq/powernow-k8.c
> +++ b/drivers/cpufreq/powernow-k8.c
> @@ -1043,7 +1043,7 @@ static int powernowk8_cpu_init(struct cpufreq_policy *pol)
>
> data = kzalloc(sizeof(*data), GFP_KERNEL);
> if (!data) {
> - pr_err("unable to alloc powernow_k8_data");
> + pr_err("unable to alloc powernow_k8_data\n");
> return -ENOMEM;
> }

Acked-by: Viresh Kumar <[email protected]>

--
viresh