2017-09-29 11:29:30

by Jan Kiszka

Subject: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event

From: Jan Kiszka <[email protected]>

Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.

Signed-off-by: Jan Kiszka <[email protected]>
---

I didn't manage to test this so far, but this looked strange while
reading the code.

trace-view-store.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trace-view-store.c b/trace-view-store.c
index 2ec52c8..f5d0a04 100644
--- a/trace-view-store.c
+++ b/trace-view-store.c
@@ -1254,7 +1254,7 @@ static void update_filter_tasks(TraceViewStore *store)
"pid");

store->sched_wakeup_new_event =
- pevent_find_event_by_name(pevent, "sched", "sched_wakeup");
+ pevent_find_event_by_name(pevent, "sched", "sched_wakeup_new");
if (store->sched_wakeup_new_event)
store->sched_wakeup_new_pid_field =
pevent_find_any_field(store->sched_wakeup_new_event,
--
2.12.3

2017-09-29 11:49:38

by Jan Kiszka

Subject: Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event

On 2017-09-29 13:29, Jan Kiszka wrote:
> From: Jan Kiszka <[email protected]>
>
> Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
>
> Signed-off-by: Jan Kiszka <[email protected]>
> ---
>
> I didn't manage to test this so far, but this looked strange while
> reading the code.

Now I found out how it is supposed to work and can confirm that this
patch fixes a real bug.

Jan

>
> trace-view-store.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace-view-store.c b/trace-view-store.c
> index 2ec52c8..f5d0a04 100644
> --- a/trace-view-store.c
> +++ b/trace-view-store.c
> @@ -1254,7 +1254,7 @@ static void update_filter_tasks(TraceViewStore *store)
> "pid");
>
> store->sched_wakeup_new_event =
> - pevent_find_event_by_name(pevent, "sched", "sched_wakeup");
> + pevent_find_event_by_name(pevent, "sched", "sched_wakeup_new");
> if (store->sched_wakeup_new_event)
> store->sched_wakeup_new_pid_field =
> pevent_find_any_field(store->sched_wakeup_new_event,
>

--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

2017-09-29 13:01:26

by Steven Rostedt

Subject: Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event

On Fri, 29 Sep 2017 13:49:31 +0200
Jan Kiszka <[email protected]> wrote:

> On 2017-09-29 13:29, Jan Kiszka wrote:
> > From: Jan Kiszka <[email protected]>
> >
> > Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
> >
> > Signed-off-by: Jan Kiszka <[email protected]>
> > ---
> >
> > I didn't manage to test this so far, but this looked strange while
> > reading the code.
>
> Now I found out how it is supposed to work and can confirm that this
> patch fixes a real bug.
>

Thanks Jan,

I'm currently at Kernel Recipes and my time for adding patches is
extremely limited while traveling. I'll hopefully be able to get to all
this next week.

-- Steve