2017-11-01 17:51:18

by Greg Edwards

[permalink] [raw]
Subject: Re: [PATCH v2] fs: guard_bio_eod() needs to consider partitions

On Tue, Oct 24, 2017 at 11:21:48AM -0600, Greg Edwards wrote:
> guard_bio_eod() needs to look at the partition capacity, not just the
> capacity of the whole device, when determining if truncation is
> necessary.
>
> [ 60.268688] attempt to access beyond end of device
> [ 60.268690] unknown-block(9,1): rw=0, want=67103509, limit=67103506
> [ 60.268693] buffer_io_error: 2 callbacks suppressed
> [ 60.268696] Buffer I/O error on dev md1p7, logical block 4524305, async page read
>
> Fixes: 74d46992e0d9 ("block: replace bi_bdev with a gendisk pointer and partitions index")
> Signed-off-by: Greg Edwards <[email protected]>
> ---
> Changes from v1:
> * use __disk_get_part instead of disk_get_part, similar to what
> blk_partition_remap does

Al, Christoph,

Any thoughts on this version?

It would be nice to get this fixed before 4.14 goes out, as this is a
regression from previous releases.

Greg

From 1582160466198797349@xxx Tue Oct 24 17:23:21 +0000 2017
X-GM-THRID: 1582099735264682689
X-Gmail-Labels: Inbox,Category Forums